Add Unit test for AWS XRay Exporter App Runner Origin #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In open-telemetry#6141 we had added the app runner origin, but forgot to add a unit test * This PR makes such that segment.origin is OriginAppRunner when the correct attrs are set
2fffadd to
58a26e8
Compare
anuraaga
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to #6141 , add a quick unit test to confirm that setting
conventions.AttributeCloudPlatformin the attributes asaws_app_runneris enough to make thesegment.originequalOriginAppRunner.Link to tracking Issue:
N/A
Testing:
Unit test covers recently added origin.
Documentation:
N/A