feat: added support for AWS AppRunner origin #6141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the test failed but it appears unrelated to the changes |
anuraaga
approved these changes
Nov 4, 2021
NathanielRN
approved these changes
Nov 5, 2021
|
@Aneurysm9 any idea why these tests are failing? If they're unrelated do you think this could be merged? |
codeboten
reviewed
Nov 8, 2021
codeboten
approved these changes
Nov 9, 2021
NathanielRN
added a commit
to NathanielRN/opentelemetry-collector-contrib
that referenced
this pull request
Nov 23, 2021
* In open-telemetry#6141 we had added the app runner origin, but forgot to add a unit test * This PR makes such that segment.origin is OriginAppRunner when the correct attrs are set
tigrannajaryan
pushed a commit
that referenced
this pull request
Nov 26, 2021
* In #6141 we had added the app runner origin, but forgot to add a unit test * This PR makes such that segment.origin is OriginAppRunner when the correct attrs are set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the AWS AppRunner origin as a valid choice for X-Ray segment origins, and wired up the logic to parse it out of resource attributes. Also did some minor cleanups.
Spec PR for adding the
aws_app_runnerentry (unreleased at time of writing, which is why it's a hardcoded string): open-telemetry/opentelemetry-specification#2004cc @Aneurysm9 @NathanielRN