Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate for refactor of OTLP->Datadog span translation #37171

Merged
merged 22 commits into from
Jan 15, 2025
+249 −20
Merged

Add feature gate for refactor of OTLP->Datadog span translation #37171

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4ff43c1
Add feature gate for refactor of OTLP->Datadog span translation
IbraheemA Jan 13, 2025
543adc5
add toversion
IbraheemA Jan 13, 2025
baff387
fix version numbers
IbraheemA Jan 13, 2025
15450cf
Add flag in datadogconnector
IbraheemA Jan 13, 2025
fcce52b
update issue in chlog
IbraheemA Jan 13, 2025
0512659
Merge branch 'main' into add-feature-flag-for-updated-datadog-span-re…
IbraheemA Jan 13, 2025
ca79820
combine exporter and connector flags into one
IbraheemA Jan 14, 2025
8c5d22c
run make commands
IbraheemA Jan 14, 2025
6744b77
update version
IbraheemA Jan 14, 2025
118fe90
Merge branch 'main' into add-feature-flag-for-updated-datadog-span-re…
IbraheemA Jan 14, 2025
d0fb4c2
linter fixes
IbraheemA Jan 15, 2025
85fa614
linter + codeowner fixes
IbraheemA Jan 15, 2025
bce1df7
Merge branch 'main' into add-feature-flag-for-updated-datadog-span-re…
IbraheemA Jan 15, 2025
2d188dd
update generated code
IbraheemA Jan 15, 2025
479a35f
codeowners
IbraheemA Jan 15, 2025
8abed50
fix module version
IbraheemA Jan 15, 2025
2ba7f95
make generate
IbraheemA Jan 15, 2025
a6e06c7
Merge branch 'main' into add-feature-flag-for-updated-datadog-span-re…
IbraheemA Jan 15, 2025
85a1512
moved internal/datadog to pkg/datadog
IbraheemA Jan 15, 2025
08ba230
make gotidy
IbraheemA Jan 15, 2025
d3faeb0
update codeowners
IbraheemA Jan 15, 2025
1f90e98
go mod change
IbraheemA Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .chloggen/add-feature-flag-for-updated-datadog-span-receiver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: datadogexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Add a feature gate exporter.datadogexporter.EnableReceiveResourceSpansV2. Enabling this gate uses a refactored implementation of OTLP->Datadog Span translation which improves performance by 10%, and deprecates the following functionality:
- No longer checks for resource-related values (container, env, hostname) in span attributes. This previous behavior did not follow the OTel spec."

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [37077]
IbraheemA marked this conversation as resolved.
Show resolved Hide resolved
22 changes: 11 additions & 11 deletions connector/datadogconnector/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ go 1.22.0
require (
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.60.1
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor v0.60.1
github.com/DataDog/datadog-agent/pkg/proto v0.60.1
github.com/DataDog/datadog-agent/pkg/trace v0.60.1
github.com/DataDog/datadog-agent/pkg/proto v0.61.0-rc.1
IbraheemA marked this conversation as resolved.
Show resolved Hide resolved
github.com/DataDog/datadog-agent/pkg/trace v0.61.0-rc.1
github.com/DataDog/datadog-go/v5 v5.6.0
github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes v0.22.0
github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/metrics v0.22.0
Expand Down Expand Up @@ -55,8 +55,8 @@ require (
github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.62.0-devel.0.20241213165407-f95df913d2b7 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/def v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/impl-gzip v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/def v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/impl-gzip v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/collector/check/defaults v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/config/env v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/config/mock v0.60.1 // indirect
Expand All @@ -78,21 +78,21 @@ require (
github.com/DataDog/datadog-agent/pkg/logs/sources v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/logs/status/utils v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/obfuscate v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/obfuscate v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/status/health v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/telemetry v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/backoff v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/cgroups v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/cgroups v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/executable v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/filesystem v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/fxutil v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/hostname/validate v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/http v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/log v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/log v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/optional v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/pointer v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/scrubber v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/pointer v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/scrubber v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/startstop v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/statstracker v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/system v0.60.1 // indirect
Expand Down Expand Up @@ -310,7 +310,7 @@ require (
golang.org/x/sys v0.29.0 // indirect
golang.org/x/term v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/time v0.7.0 // indirect
golang.org/x/time v0.8.0 // indirect
gonum.org/v1/gonum v0.15.1 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20241104194629-dd2ea8efbc28 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241104194629-dd2ea8efbc28 // indirect
Expand Down
48 changes: 24 additions & 24 deletions connector/datadogconnector/go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions exporter/datadogexporter/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.62.0-devel.0.20241213165407-f95df913d2b7
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.60.1
github.com/DataDog/datadog-agent/comp/otelcol/otlp/testutil v0.60.1
github.com/DataDog/datadog-agent/comp/trace/compression/impl-gzip v0.60.1
github.com/DataDog/datadog-agent/comp/trace/compression/impl-gzip v0.61.0-rc.1
github.com/DataDog/datadog-agent/pkg/config/model v0.60.1
github.com/DataDog/datadog-agent/pkg/config/setup v0.60.1
github.com/DataDog/datadog-agent/pkg/logs/auditor v0.60.1 // indirect
Expand All @@ -23,9 +23,9 @@ require (
github.com/DataDog/datadog-agent/pkg/logs/sds v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/logs/sources v0.60.1
github.com/DataDog/datadog-agent/pkg/logs/status/statusinterface v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/proto v0.60.1
github.com/DataDog/datadog-agent/pkg/proto v0.61.0-rc.1
github.com/DataDog/datadog-agent/pkg/status/health v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/trace v0.60.1
github.com/DataDog/datadog-agent/pkg/trace v0.61.0-rc.1
github.com/DataDog/datadog-agent/pkg/util/hostname/validate v0.60.1
github.com/DataDog/datadog-agent/pkg/util/startstop v0.60.1 // indirect
github.com/DataDog/datadog-api-client-go/v2 v2.34.0
Expand Down Expand Up @@ -118,7 +118,7 @@ require (
github.com/DataDog/datadog-agent/comp/core/telemetry v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/def v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/def v0.60.1 // indirect
github.com/DataDog/datadog-agent/comp/trace/compression/def v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/collector/check/defaults v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/config/env v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/config/mock v0.60.1 // indirect
Expand All @@ -131,19 +131,19 @@ require (
github.com/DataDog/datadog-agent/pkg/logs/processor v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/logs/sender v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/logs/status/utils v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/obfuscate v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/obfuscate v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/telemetry v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/backoff v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/cgroups v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/cgroups v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/executable v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/filesystem v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/fxutil v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/http v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/log v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/log v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/optional v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/pointer v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/scrubber v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/pointer v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/scrubber v0.61.0-rc.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/statstracker v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/system v0.60.1 // indirect
github.com/DataDog/datadog-agent/pkg/util/system/socket v0.60.1 // indirect
Expand Down Expand Up @@ -410,7 +410,7 @@ require (
golang.org/x/sys v0.29.0 // indirect
golang.org/x/term v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/time v0.7.0 // indirect
golang.org/x/time v0.8.0 // indirect
golang.org/x/tools v0.28.0 // indirect
gonum.org/v1/gonum v0.15.1 // indirect
google.golang.org/api v0.188.0 // indirect
Expand Down
Loading
Loading