Add feature gate for refactor of OTLP->Datadog span translation #37171
+249
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshg13
reviewed
Jan 13, 2025
.chloggen/add-feature-flag-for-updated-datadog-span-receiver.yaml
Outdated
Show resolved
Hide resolved
mx-psi
reviewed
Jan 14, 2025
6 tasks
songy23
reviewed
Jan 14, 2025
songy23
reviewed
Jan 15, 2025
.github/CODEOWNERS
Outdated
| @@ -127,6 +127,7 @@ extension/sumologicextension/ @open-telemetry/collector-cont | |||
| internal/aws/ @open-telemetry/collector-contrib-approvers @Aneurysm9 @mxiamxia | |||
| internal/collectd/ @open-telemetry/collector-contrib-approvers @atoulme | |||
| internal/coreinternal/ @open-telemetry/collector-contrib-approvers @open-telemetry/collector-approvers | |||
| internal/datadog/ @open-telemetry/collector-contrib-approvers @IbraheemA @songy23 | |||
There was a problem hiding this comment.
We already have pkg/datadog, what is the benefit of having internal/datadog? From what I can tell they are the same
internal/datadog/gates.go
Outdated
|
|
||
| import "go.opentelemetry.io/collector/featuregate" | ||
|
|
||
| var ReceiveResourceSpansV2FeatureGate = featuregate.GlobalRegistry().MustRegister( |
There was a problem hiding this comment.
I would suggest moving this file to pkg/datadog then delete internal/datadog. Not worth adding a new module AFAICS
songy23
approved these changes
Jan 15, 2025
| @@ -26,7 +26,7 @@ confmap/provider/s3provider/ @open-telemetry/collector-cont | |||
| confmap/provider/secretsmanagerprovider/ @open-telemetry/collector-contrib-approvers @driverpt @atoulme | |||
|
|
|||
| connector/countconnector/ @open-telemetry/collector-contrib-approvers @djaglowski @jpkrohling | |||
| connector/datadogconnector/ @open-telemetry/collector-contrib-approvers @mx-psi @dineshg13 @ankitpatel96 @jade-guiton-dd | |||
| connector/datadogconnector/ @open-telemetry/collector-contrib-approvers @mx-psi @dineshg13 @ankitpatel96 @jade-guiton-dd @IbraheemA | |||
There was a problem hiding this comment.
You can add yourself to pkg/datadog too
|
needs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a feature gate exporter.datadogexporter.EnableReceiveResourceSpansV2. Enabling this gate uses a refactored implementation of OTLP->Datadog Span translation which improves performance by 10%, and deprecates the following functionality:
- No longer checks for resource-related values (container, env, hostname) in span attributes. This previous behavior did not follow the OTel spec.
After a migration period of 6 versions, we plan to change this to opt-out, then deprecate the old functionality after another 6 versions.
Link to tracking issue
#37077
Testing
Add unit tests for new functionality (verify that relevant span attributes aren't used). Ran collector with new feature flag enabled.
Documentation
Added changelog entry