Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] introduce FormatTime() converter function #37112

Merged
merged 5 commits into from
Jan 14, 2025
Merged

[pkg/ottl] introduce FormatTime() converter function #37112

merged 5 commits into from
Jan 14, 2025

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 9, 2025 •
edited
Loading

Description

Adds a new FormatTime(time, format) converter to convert any time to a human readable string with the specified format

Link to tracking issue

Fixes #36870

@odubajDT odubajDT marked this pull request as ready for review January 9, 2025 14:59
@odubajDT odubajDT requested a review from a team as a code owner January 9, 2025 14:59
@github-actions github-actions bot requested a review from edmocosta January 10, 2025 06:02
@odubajDT odubajDT changed the title [pkg/ottl] introduce Timestamp() converter function [pkg/ottl] introduce FormatTime() converter function Jan 10, 2025
@odubajDT odubajDT requested a review from TylerHelmuth January 10, 2025 06:03
edmocosta
edmocosta reviewed Jan 10, 2025
View reviewed changes
.chloggen/ottl-timestamp.yaml Outdated Show resolved Hide resolved
.chloggen/ottl-timestamp.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_formattime.go Show resolved Hide resolved
evan-bradley
evan-bradley approved these changes Jan 10, 2025
View reviewed changes
pkg/ottl/ottlfuncs/func_formattime.go Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_formattime.go Outdated Show resolved Hide resolved
odubajDT and others added 5 commits January 13, 2025 06:45
@odubajDT
[pkg/ottl] introduce Timestamp() converter function
3a5de89 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
rename to FormatTime
3061c5b 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @edmocosta
Apply suggestions from code review
74ab383 
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
@odubajDT
fix readme
f291133 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
polishing errors
7fc839d 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@TylerHelmuth TylerHelmuth merged commit e221594 into open-telemetry:main Jan 14, 2025
163 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@edmocosta edmocosta edmocosta approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@dmitryax dmitryax

Labels
pkg/ottl
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

Consider a Timestamp() or similar Converter in OTTL
5 participants
@odubajDT @evan-bradley @edmocosta @TylerHelmuth @dmitryax