Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/encoding] support skywalkingencoding extension #36968

Merged
merged 45 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
6d856ad
rebase upstream
JaredTan95 Dec 27, 2024
c6b87bf
works
JaredTan95 Dec 26, 2024
1babb63
add UT
JaredTan95 Dec 27, 2024
155d627
rebase upstream
JaredTan95 Dec 27, 2024
b01b7a1
rebase upstream
JaredTan95 Dec 27, 2024
3cf32a7
fix builder-config
JaredTan95 Dec 27, 2024
d8be49c
add changelog
JaredTan95 Dec 27, 2024
5b73339
add docs
JaredTan95 Dec 27, 2024
769d95b
remove unused files.
JaredTan95 Dec 27, 2024
0db3300
update codeonwners
JaredTan95 Dec 27, 2024
7202adf
update codeonwners
JaredTan95 Dec 27, 2024
707249e
fix ci
JaredTan95 Dec 27, 2024
c8d7294
fix govulncheck
JaredTan95 Dec 27, 2024
47b74b2
fix ut
JaredTan95 Dec 27, 2024
0192271
fix lint
JaredTan95 Dec 27, 2024
cd3d12d
fix crosslink
JaredTan95 Dec 27, 2024
31ab139
revert CODEOWNERS update
JaredTan95 Dec 30, 2024
9e71e46
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Dec 30, 2024
22c14f7
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Dec 31, 2024
f69ce38
revert CODEOWNER in metadata.yaml update
JaredTan95 Jan 3, 2025
a41251f
Merge branch 'skywalkingencoding_extension' of https://github.com/Jar…
JaredTan95 Jan 3, 2025
4a70980
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 6, 2025
bc148dd
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 7, 2025
7f8a860
polish
JaredTan95 Jan 8, 2025
5096705
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 8, 2025
679934a
add skywalkingencodingextension in builder-config.yaml
JaredTan95 Jan 8, 2025
be3fa00
fix ci
JaredTan95 Jan 8, 2025
f4dd596
fix docs
JaredTan95 Jan 8, 2025
feac52b
fix lint
JaredTan95 Jan 8, 2025
80a2551
update CODEOWNERS
JaredTan95 Jan 9, 2025
4f92871
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 9, 2025
57821d7
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 10, 2025
263ad93
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 10, 2025
a54b342
polish
JaredTan95 Jan 13, 2025
0849205
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 13, 2025
4fa0737
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 13, 2025
e2b2060
Merge branch 'main' into skywalkingencoding_extension
TylerHelmuth Jan 13, 2025
1738c4c
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 14, 2025
07df0b3
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 14, 2025
8f0cf4b
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 15, 2025
df929fd
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 15, 2025
4c421d8
make tidy
JaredTan95 Jan 15, 2025
9bf7f1b
fix check-collector-module-version
JaredTan95 Jan 15, 2025
4317b9c
fix ci
JaredTan95 Jan 15, 2025
d899752
Merge branch 'main' into skywalkingencoding_extension
JaredTan95 Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
polish
Signed-off-by: Jared Tan <jian.tan@daocloud.io>

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
  • Loading branch information
JaredTan95 committed Jan 13, 2025
commit a54b342c6bcc759725730c05083004d314b4607e
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ func (e *skywalkingExtension) UnmarshalTraces(buf []byte) (ptrace.Traces, error)
}

func (e *skywalkingExtension) Start(_ context.Context, _ component.Host) error {
e.unmarshaler = skywalkingProtobufTrace{}
return nil
}

Expand Down
4 changes: 3 additions & 1 deletion extension/encoding/skywalkingencodingextension/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ func NewFactory() extension.Factory {
}

func createExtension(_ context.Context, _ extension.Settings, _ component.Config) (extension.Extension, error) {
return &skywalkingExtension{}, nil
return &skywalkingExtension{
unmarshaler: skywalkingProtobufTrace{},
}, nil
}

func createDefaultConfig() component.Config {
Expand Down
Loading