-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encoding] support skywalkingencoding extension #36968
Merged
songy23
merged 45 commits into
open-telemetry:main
from
JaredTan95:skywalkingencoding_extension
Jan 16, 2025
Merged
[extension/encoding] support skywalkingencoding extension #36968
songy23
merged 45 commits into
open-telemetry:main
from
JaredTan95:skywalkingencoding_extension
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
requested review from
atoulme,
dmitryax,
MovieStoreGuy and
a team
as code owners
December 27, 2024 06:19
github-actions
bot
added
cmd/otelcontribcol
otelcontribcol command
extension/encoding
labels
Dec 27, 2024
JaredTan95
changed the title
[extension/encoding] suuport Skywalkingencoding extension
[extension/encoding] support skywalkingencoding extension
Dec 27, 2024
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
skywalkingencoding_extension
branch
from
December 27, 2024 06:28
8d1b0e5
to
b01b7a1
Compare
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
atoulme
reviewed
Dec 27, 2024
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
fatsheep9146
approved these changes
Jan 9, 2025
JaredTan95
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jan 10, 2025
MovieStoreGuy
approved these changes
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36968 +/- ##
==========================================
- Coverage 79.59% 79.59% -0.01%
==========================================
Files 2252 2255 +3
Lines 211914 211940 +26
==========================================
+ Hits 168682 168699 +17
- Misses 37562 37571 +9
Partials 5670 5670 ☔ View full report in Codecov by Sentry. |
dao-jun
approved these changes
Jan 14, 2025
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…etry#36968) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The `kafkareceiver` supports `jaeger` and `zipkin` protocol traces, and can also receive skywalkng traces via `skywalkingreceiver`. From the practical use of skywalking, we often use kafka to host large-scale traces data. However, `kafka receiver` does not support `skywalking encoding` currently. with this PR, we can fectch skywalking traces and parse it into `otlp` traces: ```yaml receivers: otlp: protocols: grpc: endpoint: 0.0.0.0:4317 kafka: encoding: skywalking_encoding topic: skywalking-segments brokers: - "localhost:9092" resolve_canonical_bootstrap_servers_only: true client_id: otel-collector group_id: otel-collector metadata: retry: max: 10 backoff: 5s exporters: debug: processors: batch: extensions: health_check: pprof: endpoint: :1888 zpages: endpoint: :55679 skywalking_encoding: service: extensions: [pprof, zpages, skywalking_encoding, health_check] pipelines: traces: receivers: [kafka] processors: [batch] exporters: [debug] ``` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#28693 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/otelcontribcol
otelcontribcol command
extension/encoding
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
kafkareceiver
supportsjaeger
andzipkin
protocol traces, and can also receive skywalkng traces viaskywalkingreceiver
.From the practical use of skywalking, we often use kafka to host large-scale traces data. However,
kafka receiver
does not supportskywalking encoding
currently.with this PR, we can fectch skywalking traces and parse it into
otlp
traces:Link to tracking issue
Fixes #28693
Testing
Documentation