[chore] update references to logging exporter #30408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Need to fix cmd/otelcontribcol/exporters_test.go https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7482018448/job/20364808306?pr=30408#step:8:67
97e92b7 to
9a796ae
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
There are a few places where we probably don't need the logging exporter anymore. Updating the local builds to only include the debug exporter instead of both the logging and the debug exporter. Signed-off-by: Alex Boten <aboten@lightstep.com>
1dc8345 to
7aa8f20
Compare
|
@songy23 just rebased once again, PTAL |
songy23
reviewed
Jan 29, 2024
songy23
approved these changes
Jan 29, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
There are a few places where we probably don't need the logging exporter anymore. Updating the local builds to only include the debug exporter instead of both the logging and the debug exporter. --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where we probably don't need the logging exporter anymore. Updating the local builds to only include the debug exporter instead of both the logging and the debug exporter.