Skip to content

Commit

Permalink
[chore] update references to logging exporter
Browse files Browse the repository at this point in the history
There are a few places where we probably don't need the logging exporter anymore. Updating the local builds to only include the debug exporter instead of both the logging and the debug exporter.

Signed-off-by: Alex Boten <aboten@lightstep.com>
  • Loading branch information
Alex Boten committed Jan 29, 2024
1 parent a13a115 commit 7aa8f20
Show file tree
Hide file tree
Showing 15 changed files with 10 additions and 25 deletions.
1 change: 0 additions & 1 deletion cmd/otelcontribcol/builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ extensions:

exporters:
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.93.1-0.20240125183026-3cacd40b27e8
- gomod: go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240124123350-9047c0e373f9
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240124123350-9047c0e373f9
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240124123350-9047c0e373f9
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alertmanagerexporter v0.93.0
Expand Down
2 changes: 0 additions & 2 deletions cmd/otelcontribcol/components.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions cmd/otelcontribcol/exporters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@ func TestDefaultExporters(t *testing.T) {
{
exporter: "debug",
},
{
exporter: "logging",
},
{
exporter: "opencensus",
getConfigFn: func() component.Config {
Expand Down
1 change: 0 additions & 1 deletion cmd/otelcontribcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ require (
go.opentelemetry.io/collector/consumer v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/debugexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/extension v0.93.1-0.20240125183026-3cacd40b27e8
Expand Down
2 changes: 0 additions & 2 deletions cmd/otelcontribcol/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion cmd/oteltestbedcol/builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ extensions:

exporters:
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.93.1-0.20240125183026-3cacd40b27e8
- gomod: go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240125183026-3cacd40b27e8
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240125183026-3cacd40b27e8
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240125183026-3cacd40b27e8
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/carbonexporter v0.93.0
Expand Down
2 changes: 0 additions & 2 deletions cmd/oteltestbedcol/components.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion cmd/oteltestbedcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ require (
go.opentelemetry.io/collector/connector v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/debugexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/extension v0.93.1-0.20240125183026-3cacd40b27e8
Expand Down
2 changes: 0 additions & 2 deletions cmd/oteltestbedcol/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions examples/secure-tracing/otel-collector-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ processors:
batch:

exporters:
logging:
debug:
verbosity: detailed

service:
pipelines:
traces:
receivers: [otlp]
processors: [batch]
exporters: [logging]
exporters: [debug]

2 changes: 1 addition & 1 deletion extension/healthcheckextension/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ require (
go.opentelemetry.io/collector/connector v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/consumer v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/exporter v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/exporter/debugexporter v0.93.0 // indirect
go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
go.opentelemetry.io/collector/extension/auth v0.93.1-0.20240125183026-3cacd40b27e8 // indirect
Expand Down
4 changes: 2 additions & 2 deletions extension/healthcheckextension/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion testbed/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ require (
go.opentelemetry.io/collector/confmap v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/consumer v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/loggingexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/debugexporter v0.93.0
go.opentelemetry.io/collector/exporter/otlpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.93.1-0.20240125183026-3cacd40b27e8
go.opentelemetry.io/collector/extension v0.93.1-0.20240125183026-3cacd40b27e8
Expand Down
4 changes: 2 additions & 2 deletions testbed/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions testbed/testbed/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package testbed // import "github.com/open-telemetry/opentelemetry-collector-con

import (
"go.opentelemetry.io/collector/exporter"
"go.opentelemetry.io/collector/exporter/loggingexporter"
"go.opentelemetry.io/collector/exporter/debugexporter"
"go.opentelemetry.io/collector/exporter/otlpexporter"
"go.opentelemetry.io/collector/exporter/otlphttpexporter"
"go.opentelemetry.io/collector/extension"
Expand Down Expand Up @@ -51,7 +51,7 @@ func Components() (
errs = multierr.Append(errs, err)

exporters, err := exporter.MakeFactoryMap(
loggingexporter.NewFactory(),
debugexporter.NewFactory(),
opencensusexporter.NewFactory(),
otlpexporter.NewFactory(),
otlphttpexporter.NewFactory(),
Expand Down

0 comments on commit 7aa8f20

Please sign in to comment.