-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humio exporter init #3022
Humio exporter init #3022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
+ Coverage 91.55% 91.59% +0.04%
==========================================
Files 464 467 +3
Lines 22846 22921 +75
==========================================
+ Hits 20916 20994 +78
+ Misses 1437 1436 -1
+ Partials 493 491 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
To make the test coverage check pass
@jpkrohling I am not trying to exert any pressure, just wanted to make sure this PR does not drown, since I can see I have made it to the second page over the weekend. I added some placeholder tests to the unimplemented parts of the trace exporter to satisfy the code coverage check. All the checks are passing now. |
Thanks for pinging me, I would have missed it otherwise. I'll check it soon. |
Approved. I had a few comments that might be addressed in the next PR. |
Thank you for the review and comments. I will make sure to address them all in the next PR. |
@tigrannajaryan, @bogdandrutu would one of you please merge this one? Despite my comments, this is approved and I trust @Xitric is addressing them in the next PR. |
@tigrannajaryan I see there were some big changes to configurations, so I understand why this could not wait ;) I figured that I might as well address all the comments at once. I have updated the tests as appropriate, and everything seems to be working again. Thank you for the thorough code reviews, it is greatly appreciated! |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This is the first PR for the Humio exporter, containing readme, configuration, factory, and relevant tests. The first series of PRs will focus on implementing exporting of traces, with logs to follow soon. Apologies for the large PR, but I hope that the changes are sufficiently trivial. **Link to tracking Issue:** open-telemetry#3021 **Testing:** - `config_test.go`: Tests that the configuration options can be correctly loaded, including defaults. Also tests configuration sanitization. - `factory-test.go`: Tests that a factory only creates a new exporter (currently a stub) if provided with a valid configuration. **Documentation:** Added documentation for the purpose of the exporter and all its current configuration options. This includes Humio endpoints, ingest tokens, and storage options for Humio. Also added examples of configuring the exporter at various degrees of detail. Lastly, I added references to configuration options inherited from: - [HTTP Client Configuration](https://github.com/open-telemetry/opentelemetry-collector/tree/main/config/confighttp#client-configuration) - [TLS Configuration](https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/README.md#tls-configuration-settings) - [Queueing, Retry, and Timeout Configuration](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/README.md#configuration)
…-telemetry#3022 (open-telemetry#3102) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description:
This is the first PR for the Humio exporter, containing readme, configuration, factory, and relevant tests.
The first series of PRs will focus on implementing exporting of traces, with logs to follow soon.
Apologies for the large PR, but I hope that the changes are sufficiently trivial.
Link to tracking Issue:
#3021
Testing:
config_test.go
: Tests that the configuration options can be correctly loaded, including defaults. Also tests configuration sanitization.factory-test.go
: Tests that a factory only creates a new exporter (currently a stub) if provided with a valid configuration.Documentation:
Added documentation for the purpose of the exporter and all its current configuration options. This includes Humio endpoints, ingest tokens, and storage options for Humio.
Also added examples of configuring the exporter at various degrees of detail.
Lastly, I added references to configuration options inherited from: