sumologicexporter: add graphite format #2695
Conversation
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
+ Coverage 91.37% 91.40% +0.02%
==========================================
Files 433 434 +1
Lines 21530 21617 +87
==========================================
+ Hits 19674 19758 +84
- Misses 1390 1391 +1
- Partials 466 468 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@pmm-sumo please review. |
exporter/sumologicexporter/README.md
Outdated
| - `source_category` (optional): Desired source category. Useful if you want to override the source category configured for the source. | ||
| Placeholders `%{attr_name}` will be replaced with attribute value for `attr_name`. |
There was a problem hiding this comment.
I think this is not entirely clear. Perhaps it should be marked as graphite-only or so?
There was a problem hiding this comment.
you mean graphite_template?
There was a problem hiding this comment.
source_category is independent of metric type
There was a problem hiding this comment.
Oh, right, then I would rephrase the whole section that refers to it so it's clear what's going on. Perhaps something akin to:
You can specify a template with an attribute for
source_category,source_name,source_hostorgraphite_templateusing%{attr_name}. For example,%{my_attr}, when there is an attributemy_attr: my_valuewould be expanded tomy_value.
And then refer to it for each attribute, like:
An attribute can be referred using
%{attr_name}
|
@pmm-sumo please approve when you feel good about this PR so I can take a final look and merge |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Thank you @bogdandrutu , I think we are good to merge now |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
- Add support for graphite format to sumo logic exporter - Add sanitization for carbon2 format - Replace `=` with `:` for sanitization **Link to tracking Issue:** #1498
…-telemetry#3022 (open-telemetry#3102) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description:
=with:for sanitizationLink to tracking Issue:
#1498
Testing:
Unit tests, manual tests
Documentation:
Code comments