[exporters/signalfx]: remove unnecessary default translation rules #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
reviewed
Mar 12, 2021
asuresh4
reviewed
Mar 12, 2021
bd64764 to
00add95
Compare
asuresh4
reviewed
Mar 12, 2021
asuresh4
reviewed
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
- Coverage 91.41% 91.40% -0.01%
==========================================
Files 435 435
Lines 21620 21620
==========================================
- Hits 19764 19762 -2
- Misses 1390 1391 +1
- Partials 466 467 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
00add95 to
fdbd71a
Compare
fdbd71a to
4a6e56a
Compare
| container.network.io.usage.tx_errors: network.usage.tx_errors | ||
| container.network.io.usage.tx_packets: network.usage.tx_packets | ||
| add_dimensions: | ||
| plugin: docker |
There was a problem hiding this comment.
Aren't docker metric mappings dependent on MEAT-2298?
There was a problem hiding this comment.
Yeah they are. From slack convo I had thought we were going to remove these translations and let docker metrics send as-is, since we're suggesting users use the sfx agent docker monitor.
asuresh4
approved these changes
Mar 12, 2021
dmitryax
approved these changes
Mar 16, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-opening from #2569 after more testing