Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporters/signalfx]: remove unnecessary default translation rules #2569

Closed
wants to merge 1 commit into from

Conversation

mstumpfx
Copy link

@mstumpfx mstumpfx commented Mar 6, 2021

These will be handled by the back-end.

@mstumpfx mstumpfx requested a review from a team March 6, 2021 00:26
@mstumpfx mstumpfx changed the title [exporters/signalfx]: remove unncessary default translation rules [exporters/signalfx]: remove unnecessary default translation rules Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #2569 (2d0cabf) into main (cbb53a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         429      429           
  Lines       21457    21457           
=======================================
  Hits        19593    19593           
  Misses       1395     1395           
  Partials      469      469           
Flag Coverage Δ
integration 69.18% <ø> (ø)
unit 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb53a8...2d0cabf. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrcamp
Copy link
Contributor

jrcamp commented Mar 8, 2021

I think the exclusion list still needs to be updated as @asuresh4 pointed out in chat.

@mstumpfx
Copy link
Author

mstumpfx commented Mar 8, 2021

I think the exclusion list still needs to be updated as @asuresh4 pointed out in chat.

Yep, still working on that. I'll push another commit later.

@mstumpfx mstumpfx closed this Mar 12, 2021
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.17.0...v0.18.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants