Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/telemetrygen] Improvements and fixes to telemetrygen traces #21629

Merged
merged 16 commits into from
Aug 7, 2023
Merged

[cmd/telemetrygen] Improvements and fixes to telemetrygen traces #21629

merged 16 commits into from
Aug 7, 2023

Conversation

liustanley
Copy link
Contributor

@liustanley liustanley commented May 8, 2023 •
edited
Loading

Description:

  • Adds new option to disable the batchspanprocessor for testing large trace sizes (enabled by default)
  • Adds new option to configure size in MB of each trace generated for load testing
  • Fixes issue where large trace payloads (>2000) wouldn't generate the correct number of traces, needed to add delay after each trace is generated

@liustanley liustanley requested a review from a team May 8, 2023 18:59
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label May 8, 2023
mx-psi
mx-psi reviewed May 9, 2023
View reviewed changes
.chloggen/telemetrygen-traces-update.yaml Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/traces/worker.go Show resolved Hide resolved
cmd/telemetrygen/internal/traces/worker.go Outdated Show resolved Hide resolved
@liustanley liustanley requested a review from mx-psi May 11, 2023 16:11
mx-psi
mx-psi previously requested changes May 16, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #21629 (comment), let's remove the time.Sleep and associated changelog entry and unit test changes and focus the PR on the other improvements

.chloggen/telemetrygen-traces-fix-service-name-and-large-payloads.yaml Outdated Show resolved Hide resolved
.chloggen/telemetrygen-traces-batch-size-options.yaml Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/traces/config.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/traces/config.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/traces/worker.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/traces/worker.go Show resolved Hide resolved
cmd/telemetrygen/internal/traces/worker_test.go Outdated Show resolved Hide resolved
@liustanley liustanley mentioned this pull request May 26, 2023
Closed
liustanley and others added 3 commits May 26, 2023 11:14
@liustanley @mx-psi
Update .chloggen/telemetrygen-traces-fix-service-name-and-large-paylo…
4f94551 
…ads.yaml

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@liustanley @mx-psi
Update cmd/telemetrygen/internal/traces/config.go
ab9cfb3 
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@liustanley
PR comments
39a9e2e
@liustanley liustanley requested a review from mx-psi May 26, 2023 19:26
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 20, 2023
@mx-psi mx-psi removed the Stale label Jun 26, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 11, 2023
codeboten
codeboten reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mx-psi ptal as you have a request for change

cmd/telemetrygen/internal/traces/worker.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jul 12, 2023
@mx-psi mx-psi dismissed their stale review July 14, 2023 09:43

blocking concern was addressed

@mx-psi
Copy link
Member

mx-psi commented Jul 14, 2023

Sorry for the long delay. I have not further comments other than adressing @codeboten's question

@liustanley liustanley requested a review from codeboten July 14, 2023 20:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 1, 2023
@mx-psi
Copy link
Member

mx-psi commented Aug 1, 2023 •
edited
Loading

@liustanley can you fix the merge conflict? will merge after that

@github-actions github-actions bot removed the Stale label Aug 2, 2023
@mx-psi mx-psi merged commit ce454b5 into open-telemetry:main Aug 7, 2023
@github-actions github-actions bot added this to the next release milestone Aug 7, 2023
@mx-psi mx-psi mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees

@dmitryax dmitryax

Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Milestone
v0.83.0
Development

Successfully merging this pull request may close these issues.
4 participants
@liustanley @mx-psi @codeboten @dmitryax