Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/telemetrygen] Flaky TestRateOfMetrics on Windows #24976

Closed
mx-psi opened this issue Aug 7, 2023 · 1 comment
Closed

[cmd/telemetrygen] Flaky TestRateOfMetrics on Windows #24976

mx-psi opened this issue Aug 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues cmd/telemetrygen telemetrygen command flaky test a test is flaky needs triage New item requiring triage priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 7, 2023

Component(s)

cmd/telemetrygen

Describe the issue you're reporting

The windows-unittest-matrix (other) job has recently failed on main on the TestRateOfMetrics from cmd/telemetrygen after merging #21629 (not sure if related)

2023-08-07T10:05:04.709Z	INFO	metrics/metrics.go:92	generation of metrics isn't being throttled
2023-08-07T10:05:04.772Z	INFO	metrics/worker.go:67	metrics generated	{"worker": 0, "metrics": 5}
--- FAIL: TestRateOfMetrics (0.55s)
    worker_test.go:81: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/telemetrygen/internal/metrics/worker_test.go:81
        	Error:      	Should be true
        	Test:       	TestRateOfMetrics
        	Messages:   	there should have been more than 6 metrics, had 5
2023-08-07T10:05:06.380Z	INFO	metrics/metrics.go:92	generation of metrics isn't being throttled
2023-08-07T10:05:07.478Z	INFO	metrics/worker.go:67	metrics generated	{"worker": 0, "metrics": 151879}
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen/internal/metrics	2.857s
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen/internal/traces	1.632s
FAIL

We should fix this!

@mx-psi mx-psi added bug Something isn't working priority:p2 Medium ci-cd CI, CD, testing, build issues flaky test a test is flaky cmd/telemetrygen telemetrygen command needs triage New item requiring triage labels Aug 7, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Aug 7, 2023

Closing as duplicate of #21212, sorry!

@mx-psi mx-psi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues cmd/telemetrygen telemetrygen command flaky test a test is flaky needs triage New item requiring triage priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

2 participants