Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/sqlquery] Support of Start and Stop timestamp value Column #18925

Closed
Pranav-SA opened this issue Feb 27, 2023 · 5 comments
Closed

[receiver/sqlquery] Support of Start and Stop timestamp value Column #18925

Pranav-SA opened this issue Feb 27, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request receiver/sqlquery SQL query receiver Stale

Comments

@Pranav-SA
Copy link
Contributor

Pranav-SA commented Feb 27, 2023

Component(s)

receiver/sqlquery

Is your feature request related to a problem? Please describe.

Currently, the SQL query receiver can add the current timestamp to metrics. Adding support for optional starting and ending timestamp value columns would be helpful. This will allow users to put timestamp-based checks to retrieve values from the table with where conditions and set timestamp if provided. This avoids stale data fetch if queried at regular intervals.

Describe the solution you'd like

The start and stop timestamp fields can be added to metric cfg with corresponding checks.

StartTsColumn string mapstructure:"start_ts_column"
StopTsColumn string mapstructure:"stop_ts_column"

Describe alternatives you've considered

No response

Additional context

No response

@Pranav-SA Pranav-SA added enhancement New feature or request needs triage New item requiring triage labels Feb 27, 2023
@github-actions github-actions bot added the receiver/sqlquery SQL query receiver label Feb 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@Pranav-SA Pranav-SA changed the title Support of Start and Stop timestamp value Column [receiver/sqlquery] Support of Start and Stop timestamp value Column Feb 27, 2023
@atoulme atoulme removed the needs triage New item requiring triage label Mar 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 8, 2023
@Pranav-SA
Copy link
Contributor Author

The issue is still relevant. The proposed solution has been approved #19160 . Waiting for workflows.

@github-actions github-actions bot removed the Stale label May 26, 2023
jpkrohling added a commit that referenced this issue Jun 27, 2023
…19160)

In this PR, support for Start and Stop Timestamp to be picked up from
the metrics stored in the rows is added. This will allow SQL queries to
be more expressive and allows users to define the period of aggregation
which is not only dependent on the default system time set upon
processing.

**Link to tracking Issue:** 
#18925 
#14146

---------

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@Pranav-SA
Copy link
Contributor Author

Resolved #19160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/sqlquery SQL query receiver Stale
Projects
None yet
Development

No branches or pull requests

2 participants