Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/sqlquery] Timestamp column for a query to override collection time #14146

Closed
dehaansa opened this issue Sep 15, 2022 · 3 comments
Closed

[receiver/sqlquery] Timestamp column for a query to override collection time #14146

dehaansa opened this issue Sep 15, 2022 · 3 comments
Labels
closed as inactive enhancement New feature or request priority:p2 Medium receiver/sqlquery SQL query receiver Stale

Comments

@dehaansa
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Sometimes data has a timestamp column that specifies the time the data was collected/calculated/updated. The receiver currently ignores that data in favor of stamping the metrics with the current time at collection.

Describe the solution you'd like

It would be useful to provide a query level config of timestamp_column or similar to identify the timestamp that the metrics should be stamped with.

Describe alternatives you've considered

No response

Additional context

No response
@dehaansa dehaansa added enhancement New feature or request needs triage New item requiring triage labels Sep 15, 2022
@evan-bradley evan-bradley added priority:p2 Medium receiver/sqlquery SQL query receiver and removed needs triage New item requiring triage labels Sep 16, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @dmitryax @pmcollins. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@Pranav-SA Pranav-SA mentioned this issue Mar 1, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
jpkrohling added a commit that referenced this issue Jun 27, 2023
@Pranav-SA @jpkrohling
[receiver/sqlquery] Add support of optional Start and Stop Timestamp (#…
c4dd245 
…19160)

In this PR, support for Start and Stop Timestamp to be picked up from
the metrics stored in the rows is added. This will allow SQL queries to
be more expressive and allows users to define the period of aggregation
which is not only dependent on the default system time set upon
processing.

**Link to tracking Issue:** 
#18925 
#14146

---------

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed as inactive enhancement New feature or request priority:p2 Medium receiver/sqlquery SQL query receiver Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dehaansa @evan-bradley