feat(gator): print object name on test output #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Duologic <jeroen@simplistic.be>
368ec65 to
2474d56
Compare
|
Thanks for the PR! |
Signed-off-by: Duologic <jeroen@simplistic.be>
|
Fixed the unit test. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3018 +/- ##
==========================================
- Coverage 52.55% 52.47% -0.08%
==========================================
Files 134 134
Lines 11901 11937 +36
==========================================
+ Hits 6254 6264 +10
- Misses 5155 5181 +26
Partials 492 492
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Mattes83
pushed a commit
to Mattes83/gatekeeper
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Duologic <jeroen@simplistic.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running
gator test -f="directory/", it doesn't tell which file is violating the constraint. This may be fine for a small set of manifests but becomes annoying when validating large sets.Special notes for your reviewer:
This is my first contribution here. The attempt I'm making aims to have a small footprint but that may be the completely wrong approach for this.