feat(gator): print object name on test output (#3018)

Signed-off-by: Duologic <jeroen@simplistic.be>
open-policy-agent · Sep 26, 2023 · cbfcdde · cbfcdde
1 parent 3e66ee2
commit cbfcdde
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/cmd/gator/test/gatortest_test.go b/cmd/gator/test/gatortest_test.go
@@ -41,7 +41,7 @@ func Test_formatOutput(t *testing.T) {
 				ViolatingObject: barObject,
 				Trace:           nil,
 			}},
-			expectedOutput: `[""] Message: ""
+			expectedOutput: `/ : [""] Message: ""
 `,
 		},
 		{

diff --git a/cmd/gator/test/test.go b/cmd/gator/test/test.go
@@ -174,7 +174,24 @@ func formatOutput(flagOutput string, results []*test.GatorResult, stats []*instr
 		var buf bytes.Buffer
 		if len(results) > 0 {
 			for _, result := range results {
-				buf.WriteString(fmt.Sprintf("[%q] Message: %q\n", result.Constraint.GetName(), result.Msg))
+				obj := fmt.Sprintf("%s/%s %s",
+					result.ViolatingObject.GetAPIVersion(),
+					result.ViolatingObject.GetKind(),
+					result.ViolatingObject.GetName(),
+				)
+				if result.ViolatingObject.GetNamespace() != "" {
+					obj = fmt.Sprintf("%s/%s %s/%s",
+						result.ViolatingObject.GetAPIVersion(),
+						result.ViolatingObject.GetKind(),
+						result.ViolatingObject.GetNamespace(),
+						result.ViolatingObject.GetName(),
+					)
+				}
+				buf.WriteString(fmt.Sprintf("%s: [%q] Message: %q\n",
+					obj,
+					result.Constraint.GetName(),
+					result.Msg,
+				))
 
 				if result.Trace != nil {
 					buf.WriteString(fmt.Sprintf("Trace: %v", *result.Trace))