-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #1335
Upgrade dependencies #1335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
- Coverage 48.52% 48.44% -0.09%
==========================================
Files 68 68
Lines 4913 4913
==========================================
- Hits 2384 2380 -4
- Misses 2179 2181 +2
- Partials 350 352 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to exclude libwasmtime.a files? looks like they add ~175 MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As discussed in the call yesterday, let's hold until v3.5 is cut
+1 to excluding the wasm stuff if it's easy. We don't use it. |
How do we exclude the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Not sure how we could exclude that large binary other than scripting it after we go mod vendor
, or verifying with opa if it was included erroneously.
Run go get -u, upgrading many of our dependencies. Fixes open-policy-agent#1298 by upgrading opa to v0.29.4. Signed-off-by: Will Beason <willbeason@google.com>
@tsandall can you pls help confirm if the libwasmtime.a files were included in opa intentionally? Thanks! |
Yes, it's intentional. We (@willbeason and myself) chatted about this yesterday on the biweekly call. I'm not aware of a better solution at this point in time. If the wasmtime dependency ends up causing issues, let us know. |
Run go get -u, upgrading many of our dependencies.
Fixes #1298 by upgrading opa to v0.29.4.
Note that due to vendoring
github.com/bytecodealliance/wasmtime-go
(transitively required via open-policy-agent/opa), we include several very large binary files (See: vendor/github.com/bytecodealliance/wasmtime-go/build/linux-x86_64/libwasmtime.a). The open-policy-agent/opa library vendors this as well, so it seems fine.We are unable to safely upgrade to k8s 1.21 libraries until controller-runtime has a stable v0.9.0 release. That can be done later.
Signed-off-by: Will Beason willbeason@google.com