-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #122
Upgrade dependencies #122
Conversation
b66d7af
to
175844e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
175844e
to
3f2f430
Compare
@@ -19,18 +19,13 @@ spec: | |||
- name: v1alpha1 | |||
schema: | |||
openAPIV3Schema: | |||
description: ConstraintTemplate is the Schema for the constrainttemplates | |||
API | |||
description: ConstraintTemplate is the Schema for the constrainttemplates API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julianKatz this is the same line break diff I'm seeing as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is version skew against the version of controller-gen used. Did we dockerize that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe kustomize
unit test failed:
|
3f2f430
to
81a521b
Compare
Ah, I found it. |
b75519f
to
ce2161d
Compare
ce2161d
to
92f575b
Compare
@willbeason were you able to find the cause of unit test failure? |
92f575b
to
f2075d2
Compare
Ah, I see. The GitHub Action was setting up Go 1.15 but we need 1.16. Fixed. |
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 42.19% 42.19%
=======================================
Files 35 35
Lines 2766 2766
=======================================
Hits 1167 1167
Misses 1234 1234
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
f2075d2
to
434ec64
Compare
Use go get -u to upgrade dependencies. Use git lfs to track the 186MB of *.a files for wasmtime that we don't actually need. Signed-off-by: Will Beason <willbeason@google.com>
434ec64
to
5a36034
Compare
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use go get -u to upgrade dependencies.
Related to: open-policy-agent/gatekeeper#1335
The big thing here is upgrading opa from v0.24.0 to v0.29.4.
We are unable to safely upgrade to k8s 1.21 libraries until controller-runtime has a stable v0.9.0 release. That can be done later.
Remove installing opa v0.10 directly in the docker image as it seems vestigial and is no longer required.
Signed-off-by: Will Beason willbeason@google.com