Don't require a C++ compiler #9075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gracefully ignore the lack of a C++ compiler. Specifically, do not invoke AC_PROG_CXXCPP unless we actually found a C++ compiler. Also remove a spurious check for $CXX to be empty (which, by the very comment above it, will never be true). Signed-off-by: Ralph Castain <rhc@pmix.org> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
The original commit wasn't quite right because it would override what the user set for The comment in the code described the problem already; the real root of the problem was just that |
jsquyres
approved these changes
Jun 17, 2021
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully ignore the lack of a C++ compiler
Signed-off-by: Ralph Castain rhc@pmix.org