-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the news for v5.0.x branch. #10084
Conversation
1f6147d
to
3830c23
Compare
48f09dd
to
f8ccecc
Compare
bot:aws:retest |
These are legit CI errors:
|
Will fix today. |
f8ccecc
to
b45ea96
Compare
Should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave up before reaching the bottom. Please edit this a bit. Here's some guidelines:
- Don't list user's email addresses. We don't need to publish those for spammers to harvest.
- Only list external contributors. If someone works for one of the Open MPI regular community member organizations, we don't need to list them.
- This file is mean to be proper english. Do not use abbreviated words (e.g., "collective ops" should be "MPI collective operations"), do not use the git commit style ("section: brief description"). Write proper english sentences with good grammar, punctuation, and capitalization.
- Only mention things that are visible to users. Don't bother mentioning internal implementation details that have changed and are either largely or entirely invisible to the user.
- Describe changes in the context of what the user will notice. E.g., don't say that coll/uct was added, say that UCX support was added for MPI collective operations when not using the UCX PML.
- Group similar bullets together into sub-bullets. E.g., gather all the Fortran bullets and put them under one top-level "* Fortran updates" bullet (or something like that).
- You can/will need to significantly re-order the bullets to do this.
- I didn't see a bullet about the all-new documentation. There should be a top-level bullet about the new docs (and the https://docs.open-mpi.org/ web site) and then group all docs-related bullets under that (there were several docs bullets about people who helped along the way).
- Don't list one bullet down low, and then have another bullet above it that contradicts it. Read through the entire list and make sure that this list is cohesive and self-consistent.
This is a document. It is not just a collection of independent bullets.
0a8a468
to
d5b3ceb
Compare
docs/news/news-v5.0.x.rst
Outdated
- Updated to use PMIx ``v4.2`` branch - current hash: ``1b86a35``. | ||
- Updated to use PRRTE ``v2.1`` branch - current hash: ``91f791e``. | ||
|
||
- New MPI-4.0 features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we release, we should have a disclaimer here stating that while Open MPI v5.0.0 is NOT yet MPI-4.0 compliant, we do have a number of MPI-4.0 features implemented for developers to begin to use.
I'd also recommend moving the New MPI-4.0 features down below some of our important changes from v4.1... since majority of users will have older MPI codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets address all of these in a post rc4 update.
docs/news/news-v5.0.x.rst
Outdated
|
||
- New MPI-4.0 features: | ||
|
||
- Support for ``MPI Sesisons`` has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a link to (https://github.com/open-mpi/ompi-tests-public/tree/master/sessions) where users can find our MPI Sessions test cases.
d5b3ceb
to
7a6db11
Compare
which was removed with the readthedocs change. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
7a6db11
to
8ff7be6
Compare
bot:aws:retest |
We think we resolved all suggestions. We will have another pass at documentation before release.
This is bringing back the news from 66ecc05,
which was removed with the readthedocs change.
Signed-off-by: Austen Lauria awlauria@us.ibm.com