Project itz fixes v2 (Klaas) to master #1379
Conversation
…nents/InternalWall.mo
Stack effect airflow
WallUnitTest update for interzonal airflow v2
… baseclasses folder upwards for #1244
- refactored partialsurface such that it includes CrackOrOperableDoor - CrackOrOperableDoor implements both a regular orifice equation and a door - depending on the settings of interzonalairflow the former or the latter is used - both in a window and an internal wall the operable door can be used to increase the air flow rate - control inputs are added for this - added an optional control signal for a trickle vent in a window - added unit tests for the above - the amount of diffuse/direct light entering the zone is reduced/increased depending on the window opening control signal - an input for adding custom water vapor to the zone model ahs been added - an input for adding custom co2 to the zone model ahs been added - an output for the relative humidity has been added to the zone model - the reflection coefficient implementation in the window has been improved - the bridge type implementation has been refactored such that the user no longer must provide the bridge type length to get a reasonable estimate of the bridge
|
I changed the base branch from "stack_effect_project_itz_master" to "master". Merging the latest master branch (and solving the conflicts) changes the following reference results: IDEAS.Buildings.Components.Examples IDEAS.Buildings.Validation.Tests
IDEAS.Examples.PPD12 IDEAS.Examples.Tutorial
IDEAS.Examples.TwinHouses
|
|
The changes in IDEAS.Examples.Tutorial were strange at first sight as they do not use interzonal airflow. However, it appears that these changes can be attributed to the addition of a We decided that the new implementation is better, as the radiation of/to the window frame is not considered in the current implementation, so the use of |
@kldjonge I merged your changes into the project_itz_fixes_v2 branch of the open-ideas repo (via PR #1376). I'll use this branch to fix typos and update the reference results. If you want to change something, please pull the latest changes of the project_itz_fixes_v2 to your local branch and later create a PR to merge your changes into this branch.
If everything appears to be fine, we can merge in the stack_effect_project_itz_master branch, after which we can merge to the master branch.
@Mathadon FYI