Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen equations #1289

Closed
Mathadon opened this issue Jul 19, 2022 · 1 comment
Closed

screen equations #1289

Mathadon opened this issue Jul 19, 2022 · 1 comment
Assignees

Comments

@Mathadon
Copy link
Member

Direct solar irradiation is converted into diffuse solar irradiation? Does this make sense? Probably not since screens are typically perforated and therefore the light stays direct (except for diffraction).

  HShaDirTil = HDirTil*(1 - limiter.y);
  HShaSkyDifTil = HSkyDifTil*(1 - limiter.y) + HSkyDifTil*limiter.y*shaCorr + HDirTil*limiter.y*shaCorr;
@Mathadon Mathadon self-assigned this Jul 19, 2022
@jelgerjansen
Copy link
Contributor

@Mathadon you fixed this when working on the interzonal airflow (PR #1379). The equations now read as follows:

  HShaDirTil = HDirTil*((1 - Ctrl_internal) + Ctrl_internal*shaCorr);
  HShaSkyDifTil = HSkyDifTil*((1 - Ctrl_internal) + Ctrl_internal*shaCorr);
  HShaGroDifTil = HGroDifTil*((1 - Ctrl_internal) + Ctrl_internal*shaCorr);

Therefore I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants