-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack effect airflow #1246
Stack effect airflow #1246
Conversation
Got rid of the unnecessary initial equations
The error occurs in this model when used in a full building model: IDEAS.Buildings.Components.Interfaces.PartialSurface.PowerLaw_q50_stack. The error: But I don't know which of the conditions it assumes as non-fixed. All conditions are fixed parameters. The point of this model to either have:
|
|
||
/*ERROR: Current version of the Modelica translator can only handle | ||
*/ | ||
final parameter Boolean ColApos=StackEff and h_a>0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kldjonge can you try to add annotation(Evaluate=true)
to the definition of these variables to try to fix your issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but it doesn't seem to solve the error.
New implementation for the density columns to avoid error due to conditional statements in the column heights
Changed error in input of door component.
… and flow element(s) Assign height difference between meteorological pressure measurements and flow element(s). Also, by default corrects for the windspeed using this height when the TwoPort implementation is used.
cosmetic change
@Mathadon, everything seems to work except for the models using the IDEAS.Buildings.Components.Examples.BaseClasses.SimpleZone (Rectangular zone). They error because of a singularity without further clarification. As most examples use this implementation, I guess it is used often (?) E.g. in IDEAS.Buildings.Components.Examples.LightingControl when I change the settings to twoPort in the sim. |
option added to get better default for roofs. This needs to be fine-tuned based on available data.
Table introduced from Energy efficient guide to ventilation, Appendix 2 Table 2.1
… examples Examples not connected to case 900 for the rectangular zone template including "simulate and plot" scripts. Error for TwoPort still needs to be fixed.
At this point, a review of the implementation would be nice. If no major changes are necessary I will start to work on the CONTAM model for reference results. |
added trickle vent model for open-ideas#1232
This is a new parameter and it should probably have a default indeed! Todo FJ:
|
When an opening is horizontal, no different flows are expected due to the lack of stack effect, thus simplifying to less compartments is logical. Can this be 1?
Great that you would have a look at it so I can test it. In the meantime I updated the CONTAM model (and did some minor changes to the default modelica implementation along the way). In the CONTAM model, the stack-effect airflow trough the staircase openings is +- 50m³/h. So it will be a good case to verify the model implementation with. |
…g/Interfaces/PartialShading.mo
done in a681abf ! |
50 m3/h is substantial but not that big, for what ∆T is that? |
commit 121cb9c Merge: 06aa135 a681abf Author: kldjonge <46526840+kldjonge@users.noreply.github.com> Date: Mon Aug 29 09:00:13 2022 +0200 Merge branch 'open-ideas:master' into master commit a681abf Author: Filip Jorissen <filip.jorissen@gmail.com> Date: Sat Aug 27 16:04:04 2022 +0200 default value for epsSw_shading in IDEAS//Buildings/Components/Shading/Interfaces/PartialShading.mo
Yikes.. I tried using OpenModelica but I'm not getting a clear error message there either. |
When I put the Holzkirchen model to two ports, it only fails at initialization. Maybe you know what to do with this?
And warnings in the translation log: So it seems that the singularity error might only be related to the rectangular zone model. |
How can I couple my forked branch to this PR again? New commits don't show up here anymore because you merged it into open-ideas:StackEffectAirflow (for which I don't have write acces). Simple models with two-port airflow do seem to work just fine. |
You can just make a new PR, I think? |
Getting closer! |
Alright! What error message is thrown? |
But, so it turns out, it also happens when in the 1 port version, a cavity is added. In general I am thinking that maybe the number of available ports is the issue? Particularly the fact that when the infiltration models need 2 ports and the door model needs another 2, double connections are made at the moment (Same thing for the trickle vent model). I'm not sure what happens in these fluid-connectors when each time, a density column is used. |
The problem is that an algebraic loops is not converging. This probably either means that the system is ill-conditioned or it has no solution. I'm guessing it's the former because the cavity causes relatively large mass flow rates for small pressure drops, which can cause ill-conditioning. Can you try setting in parameter Modelica.Units.SI.PressureDifference dp_turbulent(
min=0,
displayUnit="Pa") = 0.1; (instead of 0.01) and see whether that helps? |
No that doesn't solve it. On the hunch that it might cause errors to make double use of the fluid-ports I tried to make the amount of fluid ports in the zone connector variable with the goal to then 'count' the amount of ports in the zone. I didn't manage for now because it wants to know the amount of connection beforehand. (https://github.com/kldjonge/IDEAS/tree/More-ports) |
Development of the two-port infiltration/interzonal airflow implementation introducing density-columns.