added trickle vent model for #1232 #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I correct to state that the trickle vent you added is an idealised self-regulating vent as it 'flattens out' at the design pressure drop? -> Seems like a good default for residential use, but preferably to be made replaceable in the zone model to integrate other models as well for e.g. vents without regulating mechanism or measured, tabular data. Also, you should explain me sometimes how/why you did the implementation as you did. Seeing your trickle vent model, I guess there is some optimization possible in other models as well. |
|
It indeed flattens out (after a small overshoot). Give me a call if you have specific questions =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1232. This should be unified with @kldjonge 's models from IBPSA when they get merged.