Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add client object #34

Merged
merged 6 commits into from
Dec 12, 2022
Merged

feat: Add client object #34

merged 6 commits into from
Dec 12, 2022

Conversation

josecolella
Copy link
Collaborator

This PR

Related Issues

References #7

Notes

Follow-up Tasks

How to test

@josecolella josecolella self-assigned this Nov 16, 2022
technicalpickles
technicalpickles reviewed Nov 30, 2022
View reviewed changes
@josecolella josecolella changed the title 🚧 feat: Add client object feat: Add client object Dec 12, 2022
@josecolella josecolella marked this pull request as ready for review December 12, 2022 21:52
@josecolella
add client object and initial test
fa9679d 
Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella
refactor(client): Address PR comments
188286b 
- Convert methods to dynamically created method
- Raise exception instead of returning exception class
- remove Forwardable

Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella
refactor(client): remove need for extra evaluate_flag_details and val…
1073723 
…ue methods

Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella
chore(client): fix rubocop warnings
dafc176 
Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella
chore(client): Remove forwardable and concurrent
89d7eee 
Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella
chore: Ensure client constructor arguments are keywords
4019ea9 
Signed-off-by: Jose Colella <jose.colella@gusto.com>
@josecolella josecolella enabled auto-merge (squash) December 12, 2022 22:02
@josecolella josecolella merged commit 92f8d0d into main Dec 12, 2022
@josecolella josecolella deleted the jc-add-client-object branch December 12, 2022 22:02
@github-actions github-actions bot mentioned this pull request Dec 12, 2022
Merged
@technicalpickles technicalpickles mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technicalpickles technicalpickles technicalpickles approved these changes

Assignees

@josecolella josecolella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josecolella @technicalpickles