Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge merges before CI finishes #39

Closed
technicalpickles opened this issue Dec 13, 2022 · 4 comments
Closed

Auto-merge merges before CI finishes #39

technicalpickles opened this issue Dec 13, 2022 · 4 comments
Assignees

Comments

@technicalpickles
Copy link
Collaborator

@josecolella and I saw this yesterday. It's a workflow we use during work of enabling auto-merge, so it will land when someone approves it.

Two places it didn't work as expected:

I think the fix is to make sure branch protections are on for requiring Status. While pairing with @josecolella on #34 we added the CI jobs, but unfortunately, the names have the ruby version encoded in them, which means it will change anytime Ruby version or the OS matrix changes.

In #38 I added a CI Status job that waits on everything else, which should do it. I think we just now need to updated to remove the old ones, and add CI Status to it.

Someone with admin on the repo would need to do that, as I don't currently have it.

@beeme1mr beeme1mr self-assigned this Dec 13, 2022
@beeme1mr
Copy link
Member

@technicalpickles I've updated the branch protection. I'll leave the issue open until I get confirmation that it worked.

@technicalpickles
Copy link
Collaborator Author

@beeme1mr hm, didn't quite work

CleanShot 2022-12-13 at 21 59 04@2x

It's looking for status but it's named like CI / CI Status. You might need to use the drop down thing to help select CI statuses in the last week (or whatever)

CleanShot 2022-12-13 at 22 01 22@2x

@beeme1mr
Copy link
Member

Sorry, it should be working now.

@technicalpickles
Copy link
Collaborator Author

Looks better now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants