Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aero_mode, read_line support in fake_spec_file #173

Merged
merged 29 commits into from
Nov 18, 2022

Conversation

jcurtis2
Copy link
Member

No description provided.

@slayoo
Copy link
Member

slayoo commented Sep 29, 2022

@jcurtis2 just removed one const to make it compile: c84933c

Let's add some test coverage before merging

Thanks!

@slayoo
Copy link
Member

slayoo commented Oct 4, 2022

The new macOS failures are due to this warning:

ld: warning: -undefined dynamic_lookup may not work with chained fixups

Analogous issue reported here: python/cpython#97524

@slayoo
Copy link
Member

slayoo commented Oct 5, 2022

The macOS problem seems to have been triggered by this update in Github Actions images: actions/runner-images#6225

@slayoo
Copy link
Member

slayoo commented Oct 5, 2022

trying out a workaround here: #175

@slayoo slayoo closed this Oct 5, 2022
@slayoo slayoo reopened this Oct 5, 2022
@slayoo
Copy link
Member

slayoo commented Oct 5, 2022

sorted out!

@slayoo slayoo marked this pull request as ready for review November 18, 2022 22:40
@slayoo slayoo changed the title add aero_mode add aero_mode, read_line support in fake_spec_file Nov 18, 2022
@slayoo slayoo merged commit 6f98414 into open-atmos:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants