Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Fix #2669 & #2396 - Failure to start Neovim on OSX 10.14 Mojave #2682

Merged
merged 2 commits into from
Dec 15, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Dec 14, 2018

Issue: Oni was hitting neovim/neovim#9134 when launched from finder in OSX Mojave, causing Neovim not to load.

Defect: Prior to the fix in Neovim, if the LANG environment variable was not set in OSX, Neovim would crash. Resiliency on the Neovim side is added here: neovim/neovim@57acfce

Fix: For now - we'll just set a default (overridable) value in the case where LANG is not set. Once we pick up the 0.3.2 binaries, we won't need that anymore.

Fixes #2669 & #2396

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #2682 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   45.78%   45.78%   -0.01%     
==========================================
  Files         361      361              
  Lines       14630    14634       +4     
  Branches     1924     1926       +2     
==========================================
+ Hits         6699     6700       +1     
- Misses       7701     7703       +2     
- Partials      230      231       +1
Impacted Files Coverage Δ
...src/Services/Configuration/DefaultConfiguration.ts 87.5% <ø> (ø) ⬆️
browser/src/Plugins/Api/Process.ts 52.63% <25%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1ef98...819e30c. Read the comment docs.

@bryphe bryphe merged commit 6128e77 into master Dec 15, 2018
@bryphe bryphe deleted the bryphe/2669/failure-to-launch-osx-mojave branch December 15, 2018 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed through brew, Neovim only launches when opening oni from command line
1 participant