This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix #2669 & #2396 - Failure to start Neovim on OSX 10.14 Mojave #2682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Oni was hitting neovim/neovim#9134 when launched from finder in OSX Mojave, causing Neovim not to load.
Defect: Prior to the fix in Neovim, if the
LANG
environment variable was not set in OSX, Neovim would crash. Resiliency on the Neovim side is added here: neovim/neovim@57acfceFix: For now - we'll just set a default (overridable) value in the case where
LANG
is not set. Once we pick up the0.3.2
binaries, we won't need that anymore.Fixes #2669 & #2396