Installed through brew, Neovim only launches when opening oni from command line

[kylepollina]

Oni Version: 0.3.2.1
Neovim Version (Linux only):
Operating System: macOS 10.14.1

Issue: Neovim does not load when I open Oni from the Applications folder, but it runs correctly when I launch Oni from the command line.

Expected behavior: Neovim launches when I run Oni by clicking on the icon

Actual behavior: Neovim does not launch when I run Oni by clicking on the icon. Neovim does launch when I run oni from the command line.

Steps to reproduce: Install Oni from homebrew, running 'brew cask install oni'
Launching Oni from the command line, Oni works as it is expected. However if I launch Oni by clicking on the icon from the Applications folder, it tells me Neovim is unable to launch.

[oni-bot]

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

[dsummersl]

I'm also having this problem.

[CrossR]

As I've not got a Mac, do @bryphe or @Akin909 have any input on this?

Its possible its similar to the other 10.14 issues we've been having, though I'd be surprised why there is a difference loading via the commandline and the app icon. (Though technically I think they run different scripts?)

[dsummersl]

My first guess is that it is a pathing issue...I don't know where to look in oni to see logs and such though...

[baodrate]

@dsummersl perhaps check the chrome console logs first? Help -> Developer Tools -> Console.

[dsummersl]

Thanks so much for that...I see this in the dev console:

I verified that the path to nvim does exist...and it appears to have the same logs (same nvim used) in the developer console when I launch from my command line (but without the error).

[aleksandersumowski]

I see this problem - including log line about crashing Neovim even when I launch Oni from command line using /Applications/Oni.app/Contents/MacOS/Oni

[ghost]

I believe this is another duplicate of #2396 (the other one being my own).

[bryphe]

Thanks all for reporting this! I was able to repro and found the issue - we're hitting this issue: neovim/neovim#9134 (fixed here neovim/neovim@57acfce)

It seems that previously we were getting the LANG environment variable set, but with Mojave we're not anymore. Thanks @jordan-arenstein for finding the bug and @mhinz for the fix on the Neovim side 👍

I'll release a new build of Oni with a workaround - it'll set the LANG variable if it isn't set. It's not ideal because it's hardcoded to en_us.UTF-8, but I also have a configuration key that can override this:

"environment.additionalVariables": {
  "LANG": "zh_CN.UTF-8",
},