-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow EVM] update EVM version to the one supporting configurable precompiles #5524
Changes from 1 commit
d94ef3f
76f8a45
9538340
7e17626
1fa4839
2078acc
b4dae84
7101a4c
2b4aadd
d619bf6
cdb1783
e48612e
0f5f8f5
4bdf845
27a7771
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -361,3 +361,5 @@ require ( | |
replace github.com/onflow/flow-go => ../ | ||
|
||
replace github.com/onflow/flow-go/insecure => ../insecure | ||
|
||
replace github.com/ethereum/go-ethereum v1.13.5 => github.com/onflow/go-ethereum v0.0.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we match versions (tag onflow/go-ethereum with same tag from which it's based of, so we don't make mistakes in future) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea, going to update the version to a proper one after we merge the changes on the other PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the build for anyone importing
flow-go
as a dependency (that didn't copy this replace). Would it make sense to just change all the imports?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, unfortunately, it won't work unless we replace a lot of internal references in the onflow/go-ethereum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try one more time