[Flow EVM] update EVM version to the one supporting configurable precompiles #5524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5524 +/- ##
==========================================
- Coverage 55.63% 55.61% -0.02%
==========================================
Files 1036 1036
Lines 101233 101215 -18
==========================================
- Hits 56320 56292 -28
- Misses 40590 40595 +5
- Partials 4323 4328 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
integration/go.mod
Outdated
| @@ -361,3 +361,5 @@ require ( | |||
| replace github.com/onflow/flow-go => ../ | |||
|
|
|||
| replace github.com/onflow/flow-go/insecure => ../insecure | |||
|
|
|||
| replace github.com/ethereum/go-ethereum v1.13.5 => github.com/onflow/go-ethereum v0.0.2 | |||
There was a problem hiding this comment.
should we match versions (tag onflow/go-ethereum with same tag from which it's based of, so we don't make mistakes in future)
There was a problem hiding this comment.
Good idea, going to update the version to a proper one after we merge the changes on the other PR
go.mod
Outdated
| @@ -319,3 +319,5 @@ require ( | |||
|
|
|||
| // Using custom fork until https://github.com/onflow/flow-go/issues/5338 is resolved | |||
| replace github.com/ipfs/boxo => github.com/onflow/boxo v0.0.0-20240201202436-f2477b92f483 | |||
|
|
|||
| replace github.com/ethereum/go-ethereum v1.13.5 => github.com/onflow/go-ethereum v0.0.2 | |||
There was a problem hiding this comment.
This will break the build for anyone importing flow-go as a dependency (that didn't copy this replace). Would it make sense to just change all the imports?
There was a problem hiding this comment.
I tried that, unfortunately, it won't work unless we replace a lot of internal references in the onflow/go-ethereum.
There was a problem hiding this comment.
Let me try one more time
…ow-go into ramtin/5512-update-to-evm-fork
|
@janezpodhostnik @sideninja updated the other repo onflow/go-ethereum#5 to use internal references, so this PR can skip the replace statement and import the forked repo directly. As soon as the other PR gets approved I'll update this PR with a proper version tag. |
…ow-go into ramtin/5512-update-to-evm-fork
| @@ -115,6 +115,7 @@ require ( | |||
| github.com/elastic/gosigar v0.14.2 // indirect | |||
| github.com/emirpasic/gods v1.18.1 // indirect | |||
| github.com/ethereum/c-kzg-4844 v0.4.0 // indirect | |||
| github.com/ethereum/go-ethereum v1.13.10 // indirect | |||
There was a problem hiding this comment.
why is this still used? what does go mod why say?
There was a problem hiding this comment.
I just updated the references in the EVM code base, the rest are using regular go-ethereum (e.g. RLP encoding stuff, etc)
Depends on :
Closes: #5512
This PR updates the Flow EVM to use a version of EVM that supports configurable precompiles.
While we are going to attempt to merge the changes to the upstream, we use an internal fork of EVM.