Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Simplifies RPC inspection misbehavior notification handling #5398

Merged
merged 39 commits into from
Feb 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
e7320d0
moves distributor logic into score registry
thep2p Feb 8, 2024
a5c7b8d
wip
thep2p Feb 8, 2024
9cad443
cleans up distributor and inspector suit
thep2p Feb 9, 2024
bb8ac36
renames a method on builder
thep2p Feb 9, 2024
308b780
removes inspector suite factory func
thep2p Feb 9, 2024
f1571b4
removes distributor and inspector suite interfaces
thep2p Feb 9, 2024
5e344ca
adds notification consumer to score option
thep2p Feb 9, 2024
4a63d82
moves worker pool to score registry
thep2p Feb 9, 2024
e7acb98
refactors gossipsub builder to use the inspector than suite
thep2p Feb 9, 2024
e5e86d6
adds invalid control message notification consumer as a base dependency
thep2p Feb 9, 2024
90c2bcd
removes overriding inspector suite func
thep2p Feb 9, 2024
7cde571
renames a method
thep2p Feb 9, 2024
77589bd
generates mocks
thep2p Feb 9, 2024
006768c
Revert "removes overriding inspector suite func"
thep2p Feb 12, 2024
7fde32d
Revert "removes inspector suite factory func"
thep2p Feb 12, 2024
5ee4b87
fixes rpc inspector tests
thep2p Feb 13, 2024
0e9356d
fixes inspector validation test
thep2p Feb 15, 2024
dfb2c9b
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 15, 2024
6eaa46d
fixes tests
thep2p Feb 15, 2024
e10006b
Merge branch 'yahya/simplify-rpc-inspection' of github.com:onflow/flo…
thep2p Feb 15, 2024
86a9ba4
re-generates mocks
thep2p Feb 15, 2024
2a21a44
fixing tests
thep2p Feb 16, 2024
3275b22
fixes TestScoreRegistry_SpamRecordWithoutDuplicateMessagesPenalty
thep2p Feb 16, 2024
d72ccac
fixes testScoreRegistryPeerWithSpamRecord
thep2p Feb 16, 2024
832d285
fixes TestScoreRegistry_SpamRecordWithUnknownIdentity
thep2p Feb 16, 2024
29302d6
fixes TestScoreRegistry_SpamRecordWithSubscriptionPenalty
thep2p Feb 16, 2024
27bbd0f
fixes all scoring tests
thep2p Feb 16, 2024
182bcf6
adds documentations to the gossipsub builder
thep2p Feb 16, 2024
5267830
adds documentation and renames a method
thep2p Feb 16, 2024
03fb255
adds a godoc
thep2p Feb 16, 2024
f7d5549
removes an unused function
thep2p Feb 16, 2024
149f309
adds config for size of hero store for notification queue
thep2p Feb 16, 2024
e2e837a
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 18, 2024
a5a05e9
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 20, 2024
e1edb3d
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 21, 2024
21da688
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 21, 2024
0e6358b
Merge branch 'master' into yahya/simplify-rpc-inspection
thep2p Feb 21, 2024
30d0231
comments out flakey test
thep2p Feb 22, 2024
625fa72
Merge remote-tracking branch 'origin/master' into yahya/simplify-rpc-…
thep2p Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removes overriding inspector suite func
  • Loading branch information
thep2p committed Feb 9, 2024
commit 90c2bcd294e35777bcc87b08e4bcfd34c8bf7d10
5 changes: 0 additions & 5 deletions network/p2p/builder/libp2pNodeBuilder.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,6 @@ func (builder *LibP2PNodeBuilder) OverrideNodeConstructor(f p2p.NodeConstructor)
return builder
}

func (builder *LibP2PNodeBuilder) OverrideDefaultRpcInspectorSuiteFactory(factory p2p.GossipSubRpcInspectorSuiteFactoryFunc) p2p.NodeBuilder {
builder.gossipSubBuilder.OverrideDefaultRpcInspectorSuiteFactory(factory)
return builder
}

// Build creates a new libp2p node using the configured options.
func (builder *LibP2PNodeBuilder) Build() (p2p.LibP2PNode, error) {
var opts []libp2p.Option
Expand Down