[Networking] Simplifies RPC inspection misbehavior notification handling #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5398 +/- ##
==========================================
- Coverage 56.02% 56.01% -0.02%
==========================================
Files 1026 1026
Lines 99859 99815 -44
==========================================
- Hits 55944 55909 -35
+ Misses 39618 39611 -7
+ Partials 4297 4295 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kc1116
approved these changes
Feb 21, 2024
peterargue
approved these changes
Feb 21, 2024
Comment on lines
+416
to
+417
| // TODO: we have to add a metric for this case. | ||
| // TODO: we should not have deduplication for this case, as we need to penalize the peer for each misbehaviour, we need to add a nonce to the notification. |
There was a problem hiding this comment.
are there issues for these?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly streamlines GossipSub misbehavior notification handling. Previously, notifications passed through
ControlMsgValidationInspector,GossipSubInspectorNotifDistributor, thenGossipSubAppSpecificScoreRegistry. Now, we've removedGossipSubInspectorNotifDistributor, merging its functionality intoGossipSubAppSpecificScoreRegistry, reducing the process to a direct flow fromControlMsgValidationInspectortoGossipSubAppSpecificScoreRegistry. This change not only simplifies the notification handling process but also makes it easier to debug and understand. It eliminates unnecessary layers and abstractions, enhancing the efficiency of the inspector suite by fully integrating it withControlMsgValidationInspector.