[crypto] add blst source code #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e limiters and distributor
1. Replace EnableAllLimitEnforcements/DisableAllLimitEnforcements with RunWithAllLimitsDisabled 2. Remove enforceLimit parameter from Get/Set calls. 3. Internalize meter enforceLimits check into State. This enables us to compose view implementations (meter/interaction limits view, spock view, delta, etc) in the future.
3846: Use consistent method for creating temp dirs r=jordanschalm a=jordanschalm
This PR changes integration test utilities to use a consistent method and root location when creating temporary directories for use in tests.
This is to mitigate an issue where integration tests would fail on macOS, due to a permissions issue when initializing bootstrap and data directories for Docker containers.
```
lchown /var/folders/bm/wbf3kfs91911lr5w6qyw126c0000gn/T/TestEpochJoinAndLeaveANTestEpochJoinAndLeaveAN4216456854/001/bootstrap/execution-state/00000000: operation not permitted
```
As far as I can tell, `t.TempDir()` created directories which caused `operation not permitted` errors, whereas `os.MkdirTemp("/tmp", ...)` did not. We aren't sure what causes the two methods to behave differently at this point, but using "the good one" consistently works to fix the test failure.
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
(which will create and setup staking account all in one shot)
Codecov Report
@@ Coverage Diff @@
## feature/blst-based-crypto #3851 +/- ##
=============================================================
+ Coverage 53.00% 53.16% +0.15%
=============================================================
Files 796 750 -46
Lines 73638 72796 -842
=============================================================
- Hits 39035 38700 -335
+ Misses 31425 30894 -531
- Partials 3178 3202 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* remove unused functions, add link to commit where they can be found again if needed
Prep work for changing address internal representation The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible. Note that (except for tests) I'm trying to consistently name the address variables based on their types: - address is always a flow.Address - runtimeAddress is a common.Address - cadenceAddress is a cadence.Address
3912: Clean up address usage (part 1 of many) r=pattyshack a=pattyshack Prep work for changing address internal representation The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible. Note that (except for tests) I'm trying to consistently name the address variables based on their types: - address is always a flow.Address - runtimeAddress is a common.Address - cadenceAddress is a cadence.Address Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com>
FVM Benchstat comparisonThis branch with compared with the base branch onflow:feature/blst-based-crypto commit 7ca2a9f The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is the first PR of a long epic (BLST-based crypto), code will continue to change significantly. The epic is implemented into multiple PRs to use continuous CI testing. The epic purpose is to substitute Relic by BLST, both libraries are used by the core crypto code to perform low level math operations.
/blst_src)blst_src.candblst_assembly.S