Clean up address usage (part 1 of many) #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 48e38e6 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
c141bf0 to
0d286a4
Compare
janezpodhostnik
approved these changes
Feb 13, 2023
0d286a4 to
e2ee169
Compare
Codecov Report
@@ Coverage Diff @@
## master #3912 +/- ##
==========================================
- Coverage 53.25% 50.82% -2.44%
==========================================
Files 821 593 -228
Lines 76839 55359 -21480
==========================================
- Hits 40923 28136 -12787
+ Misses 32601 24872 -7729
+ Partials 3315 2351 -964
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhangchiqing
approved these changes
Feb 16, 2023
e2ee169 to
93bcb44
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
3912: Clean up address usage (part 1 of many) r=pattyshack a=pattyshack Prep work for changing address internal representation The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible. Note that (except for tests) I'm trying to consistently name the address variables based on their types: - address is always a flow.Address - runtimeAddress is a common.Address - cadenceAddress is a cadence.Address Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
3912: Clean up address usage (part 1 of many) r=pattyshack a=pattyshack Prep work for changing address internal representation The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible. Note that (except for tests) I'm trying to consistently name the address variables based on their types: - address is always a flow.Address - runtimeAddress is a common.Address - cadenceAddress is a cadence.Address Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com>
|
Build failed: |
Prep work for changing address internal representation The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible. Note that (except for tests) I'm trying to consistently name the address variables based on their types: - address is always a flow.Address - runtimeAddress is a common.Address - cadenceAddress is a cadence.Address
93bcb44 to
c53b3bc
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for changing address internal representation
The number of changes is getting a bit out of hand. I'll split up the change into smaller PRs, with the goal of consistently operating on flow.Address whenever possible.
Note that (except for tests) I'm trying to consistently name the address variables based on their types: