Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows][CUDA] Fix cuda uninitialized event warning #2503

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[Windows][CUDA] Fix cuda uninitialized event warning #2503

merged 1 commit into from
Jan 3, 2025

Conversation

omarahmed1111
Copy link
Contributor

Fixes 2497

@omarahmed1111 omarahmed1111 requested review from a team as code owners December 23, 2024 14:23
@omarahmed1111 omarahmed1111 changed the title Fix cuda uninitialized event warning [CUDA] Fix cuda uninitialized event warning Dec 23, 2024
@omarahmed1111 omarahmed1111 changed the title [CUDA] Fix cuda uninitialized event warning [Windows][CUDA] Fix cuda uninitialized event warning Dec 23, 2024
@github-actions github-actions bot added cuda CUDA adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Dec 23, 2024
@ldrumm
Copy link
Contributor

ldrumm commented Dec 23, 2024

initialization in C++ is such a headache. +1

@omarahmed1111 omarahmed1111 mentioned this pull request Dec 24, 2024
Merged
@omarahmed1111 omarahmed1111 force-pushed the fix-cuda-uninitialized-event branch from 6b79917 to 82dae74 Compare December 31, 2024 03:48
@omarahmed1111 omarahmed1111 added the ready to merge Added to PR's which are ready to merge label Dec 31, 2024
@martygrant martygrant merged commit 545a01b into oneapi-src:main Jan 3, 2025
73 checks passed
martygrant added a commit to omarahmed1111/llvm that referenced this pull request Jan 6, 2025
@martygrant
[UR] Update tag to f0b3520 for oneapi-src/unified-runtime#2503
91a0e25
martygrant added a commit to omarahmed1111/llvm that referenced this pull request Jan 6, 2025
@martygrant
[UR] Update tag to f0b3520 for oneapi-src/unified-runtime#2503
66d98a8
martygrant added a commit to intel/llvm that referenced this pull request Jan 6, 2025
@omarahmed1111 @martygrant
Bump for uninitialized-cuda-events-fix (#16469)
8329e7b 
Test PR for UR
[PR](oneapi-src/unified-runtime#2503)

---------

Co-authored-by: Martin Morrison-Grant <martin.morrisongrant@codeplay.com>
@kbenzie kbenzie added the v0.11.x Include in the v0.11.x release label Jan 22, 2025
kbenzie pushed a commit that referenced this pull request Jan 22, 2025
@martygrant @kbenzie
Merge pull request #2503 from omarahmed1111/fix-cuda-uninitialized-event
18fce8e 
[Windows][CUDA] Fix cuda uninitialized event warning
kbenzie pushed a commit that referenced this pull request Jan 23, 2025
@martygrant @kbenzie
Merge pull request #2503 from omarahmed1111/fix-cuda-uninitialized-event
5cb6589 
[Windows][CUDA] Fix cuda uninitialized event warning
@kbenzie kbenzie mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldrumm ldrumm ldrumm approved these changes

@Bensuo Bensuo Bensuo approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification cuda CUDA adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cuda][windows] error C4703: potentially uninitialized local pointer variable 'Event' used"
5 participants
@omarahmed1111 @ldrumm @Bensuo @kbenzie @martygrant