Skip to content

Commit

Permalink
Merge pull request #2503 from omarahmed1111/fix-cuda-uninitialized-event
Browse files Browse the repository at this point in the history
[Windows][CUDA] Fix cuda uninitialized event warning
  • Loading branch information
martygrant authored and kbenzie committed Jan 22, 2025
1 parent 98c70a5 commit 18fce8e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions source/adapters/cuda/command_buffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ commandHandleReleaseInternal(ur_exp_command_buffer_command_handle_t Command) {
// of the `ur_event_t` object doesn't free the underlying CuEvent_t object and
// we need to do it manually ourselves.
if (Command->SignalNode) {
CUevent SignalEvent;
CUevent SignalEvent{};
UR_CHECK_ERROR(
cuGraphEventRecordNodeGetEvent(Command->SignalNode, &SignalEvent));
UR_CHECK_ERROR(cuEventDestroy(SignalEvent));
Expand Down Expand Up @@ -85,7 +85,7 @@ ur_exp_command_buffer_handle_t_::~ur_exp_command_buffer_handle_t_() {
std::unique_ptr<ur_event_handle_t_>
ur_exp_command_buffer_handle_t_::addSignalNode(CUgraphNode DepNode,
CUgraphNode &SignalNode) {
CUevent Event;
CUevent Event{};
UR_CHECK_ERROR(cuEventCreate(&Event, CU_EVENT_DEFAULT));
UR_CHECK_ERROR(
cuGraphAddEventRecordNode(&SignalNode, CudaGraph, &DepNode, 1, Event));
Expand Down Expand Up @@ -1433,7 +1433,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferUpdateSignalEventExp(
return UR_RESULT_ERROR_INVALID_OPERATION;
}

CUevent SignalEvent;
CUevent SignalEvent{};
UR_CHECK_ERROR(cuGraphEventRecordNodeGetEvent(SignalNode, &SignalEvent));

if (phEvent) {
Expand Down
2 changes: 1 addition & 1 deletion source/adapters/cuda/device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
uint64_t *pDeviceTimestamp,
uint64_t *pHostTimestamp) {
CUevent Event;
CUevent Event{};
ScopedContext Active(hDevice);

if (pDeviceTimestamp) {
Expand Down
2 changes: 1 addition & 1 deletion source/adapters/cuda/platform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ urPlatformGet(ur_adapter_handle_t *, uint32_t, uint32_t NumEntries,
UR_CHECK_ERROR(cuDevicePrimaryCtxRetain(&Context, Device));

ScopedContext Active(Context); // Set native ctx as active
CUevent EvBase;
CUevent EvBase{};
UR_CHECK_ERROR(cuEventCreate(&EvBase, CU_EVENT_DEFAULT));

// Use default stream to record base event counter
Expand Down

0 comments on commit 18fce8e

Please sign in to comment.