Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceASAN] Fix ASAN with kernel assert #2415

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Dec 4, 2024

LLVM: intel/llvm#16256

Even when the kernel is not instrumented, we still need to execute the same routine just like instrumented kernel.
That's because some of arguments have been intercepted by the sanitizer layer and are no longer compatible with the native level zero's value. For example, membuffer.

@AllanZyne AllanZyne requested a review from a team as a code owner December 4, 2024 07:49
@github-actions github-actions bot added the loader Loader related feature/bug label Dec 4, 2024
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllanZyne
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, please review and add this to 2025.1.
Thanks!

@pbalcer pbalcer added the v0.11.x Include in the v0.11.x release label Dec 13, 2024
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits, but I do have a general comment - this looks like a pretty big change in logic, with the not instrumented kernels now executing more code that was previously short-circuited with if (not instrumented) return KernelLaunch(...). Which might be fine, but there's no explanation in the commit description.

Do you have SYCL tests that exercise this path with non-instrumented kernels?

@AllanZyne
Copy link
Contributor Author

just a few nits, but I do have a general comment - this looks like a pretty big change in logic, with the not instrumented kernels now executing more code that was previously short-circuited with if (not instrumented) return KernelLaunch(...). Which might be fine, but there's no explanation in the commit description.

Ok, I will add explanation.

Do you have SYCL tests that exercise this path with non-instrumented kernels?

Thanks for reminder, I enhanced the kernel-filter test.

@AllanZyne
Copy link
Contributor Author

AllanZyne commented Dec 17, 2024

Hi @pbalcer, the commit description was updated.

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Dec 17, 2024
@martygrant martygrant merged commit d18d523 into oneapi-src:main Dec 18, 2024
73 checks passed
martygrant added a commit to intel/llvm that referenced this pull request Dec 19, 2024
UR: oneapi-src/unified-runtime#2415

---------

Co-authored-by: Martin Morrison-Grant <martin.morrisongrant@codeplay.com>
kbenzie pushed a commit that referenced this pull request Dec 19, 2024
@AllanZyne AllanZyne deleted the review/yang/fix_metadata_assert branch December 19, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants