Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable adapter tests to run on all discovered adapters. #2376

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Enable adapter tests to run on all discovered adapters. #2376

merged 1 commit into from
Dec 18, 2024

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 25, 2024 •
edited
Loading

This is the first step towards having the all the CTS tests parameterize over all available platforms (see #2378).

@github-actions github-actions bot added the conformance Conformance test suite issues. label Nov 25, 2024
@aarongreig aarongreig force-pushed the aaron/parameterizeAdapterTests branch 2 times, most recently from a1ba24a to 8b52839 Compare November 27, 2024 12:09
@github-actions github-actions bot added the native-cpu Native CPU adapter specific issues label Nov 27, 2024
@aarongreig aarongreig force-pushed the aaron/parameterizeAdapterTests branch from 8b52839 to e7c4ca0 Compare November 29, 2024 10:54
@aarongreig
Copy link
Contributor Author

this has an adapter change now so: intel/llvm#16212

@aarongreig aarongreig marked this pull request as ready for review December 2, 2024 15:57
@aarongreig aarongreig requested review from a team as code owners December 2, 2024 15:57
@aarongreig
Copy link
Contributor Author

aarongreig commented Dec 2, 2024 •
edited
Loading

could work without the adapter change included by using the macro from #2392

@aarongreig aarongreig mentioned this pull request Dec 2, 2024
Merged
@aarongreig aarongreig force-pushed the aaron/parameterizeAdapterTests branch from e7c4ca0 to c8b8b3b Compare December 16, 2024 14:36
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Dec 16, 2024
@aarongreig aarongreig force-pushed the aaron/parameterizeAdapterTests branch from c8b8b3b to 3ab955f Compare December 17, 2024 16:26
@kbenzie kbenzie merged commit 607e88d into oneapi-src:main Dec 18, 2024
70 of 73 checks passed
@kbenzie kbenzie mentioned this pull request Dec 18, 2024
Closed
martygrant added a commit to intel/llvm that referenced this pull request Dec 18, 2024
@martygrant
[UR] Update tag to d18d5239 for the following PRs:
fa1667e 
- oneapi-src/unified-runtime#2415
- oneapi-src/unified-runtime#2477
- oneapi-src/unified-runtime#2474
- oneapi-src/unified-runtime#2472
- oneapi-src/unified-runtime#1332
- oneapi-src/unified-runtime#2365
- oneapi-src/unified-runtime#2376
@martygrant martygrant mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@hvdijk hvdijk hvdijk approved these changes

@RossBrunton RossBrunton RossBrunton approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarongreig @RossBrunton @hvdijk @kbenzie