Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP-1915 Move SBATCH params to Job Script submission #194

Merged
merged 38 commits into from
Dec 19, 2022
Merged

ASP-1915 Move SBATCH params to Job Script submission #194

merged 38 commits into from
Dec 19, 2022

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Dec 5, 2022

What

Currently in Jobbergate, the extra SBATCH params used for Job Script execution must be supplied when an Application is being rendered into a Job Script. The SBATCH params are injected into the Job Script code itself. Then, when the jobs are submitted to the cluster, those params are extracted from the script and re-written as API request parameters to the Slurm REST API.

Since the SBATCH params actually control job execution, they should instead be passed as part of the Job Submission process where a Job Script is submitted for execution. To this end, they should be changed to be a property of a Job Submission.

Why

  • Make job_scripts more reusable so we should not need to create a new one from the template for every variation of params. This will result in fewer database entries and better scalability on the data backend
  • Increase the function and usability of the API so that automation tools are easier to build and integration into other platforms is simpler
  • Make things more maintainable and the existing implementation will be more flexible

Task: https://jira.scania.com/browse/ASP-1915


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

@fschuch fschuch changed the title Move SBATCH params to Job Script submission ASP-1915 Move SBATCH params to Job Script submission Dec 5, 2022
@fschuch fschuch marked this pull request as ready for review December 9, 2022 13:03
Copy link
Contributor

@dusktreader dusktreader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the feedback here, but I think there are a few fundamental things to address.

@fschuch fschuch merged commit cb5fb02 into main Dec 19, 2022
@fschuch fschuch deleted the ASP-1915 branch October 19, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants