ASP-2256 Migrate the SBATCH param mapper to jobbergate-api #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheushent
reviewed
Dec 2, 2022
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Show resolved
Hide resolved
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Show resolved
Hide resolved
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_properties_parser.py
Outdated
Show resolved
Hide resolved
matheushent
requested changes
Dec 5, 2022
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Outdated
Show resolved
Hide resolved
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Outdated
Show resolved
Hide resolved
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Outdated
Show resolved
Hide resolved
to the `job_submissions` POST endpoint
assert if mocked method is called
they now also check is the data at the database is as expected
matheushent
reviewed
Dec 6, 2022
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_properties_parser.py
Show resolved
Hide resolved
matheushent
reviewed
Dec 6, 2022
jobbergate-api/jobbergate_api/tests/apps/job_submissions/test_routers.py
Show resolved
Hide resolved
matheushent
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the
job_submissionsPOST endpointWhat
The sbatch parser was implemented successfully on the cluster-agent.
The implementation worked, but it was difficult to reflect errors to the user due to the asynchronous nature of remote job submission. Raising these errors early in the workflow will result in a better user experience, in general. Jobbergate would also present the error message and log, allowing users to act and solve the problems related to the parameters.
Why
Explain why the proposed change is necessary.
Task: https://jira.scania.com/browse/ASP-2256Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.