Temp test coverage #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stdout returned by the job runner submit method doesn't end with a newline, the `sys.stdout.write` call in `jobs_submit` do not add it and this cases submission to fails (at least to be recorded as failed by the calling process when running a workflow). Looking at how newlines are handled in the JobRunnerManager.job_kill method, it looks like this a typo in the jobs_submit method.
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Reconstruct xtriggers at reload time.
🤖 Merge 8.3.x-sync into master
* Closes cylc#6314 * There are niche situations where the job is not stored in "TaskProxy.jobs". * This handles the situation as gracefully as we are able to.
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
tui: support the home/end keys in the log view
pool: update the runahead limit after task removal
🤖 Merge 8.3.x-sync into master
graphdepth update on remove fix
🤖 Merge 8.3.x-sync into master
`log_vc_info`: add tests for when VCS not installed
Ensure `cylc trigger` does not fall back to `flow=none` by default
🤖 Merge 8.3.x-sync into master
…a-files examples: using data to define your workflow
gracefully handle SIGINT, SIGTERM and SIGHUP
task_events_mgr: handle missing job config
🤖 Merge 8.3.x-sync into master
tui: fix task state filters
🤖 Merge 8.4.x-sync into master
Deprecate async-timeout dependency
logging: update header timestamp on rollover
🤖 Merge 8.4.x-sync into master
GH Actions: don't fail fast
🤖 Merge 8.4.x-sync into master
Refactor code block into helper method
Fix potentially unbound variables
🤖 Merge 8.4.x-sync into master
PEP-515 allowed integers to be defined with underscores from python 3.6. This changes the behaviour of Cylc task parameters, as `"123_456"` can now be interpreted as an integer.
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Assume task parameters with underscores to be strings.
* Add the "remove" operation to the task context menu. * Dim no-flow tasks to make remove operations clear to the user. Closes cylc#6542 * Show workflow status in the context menu. * Show task status, attributes and task flow numbers (if not {1}) in the task context menu. * Show job status in the context menu.
🤖 Merge 8.4.x-sync into master
Remove vim.lang from syntax
pbs: update connection failed error message
🤖 Merge 8.4.x-sync into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.