Ensure cylc trigger
does not fall back to flow=none
by default
#6445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split off from #6370 as I think it's already a bug.
Problem 1
If you
cylc trigger
a task when there are no active flows (e.g. on restarting a completed workflow), it looks in the DB for the latest flow number(s). However, if the latest wasflow=none
, this would result in the task being triggered withflow=none
as well.Solution: choose the latest flow number(s) that is not
flow=none
.Problem 2
With #6370 making it so that
cylc remove
will demote tasks toflow=none
, you could end up with the situation where all tasks in the DB areflow=none
, so again this would still result in the task being triggered withflow=none
.Solution: fall back to
flow=1
.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.?.?.x
branch.