Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cylc trigger does not fall back to flow=none by default #6445

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Oct 23, 2024

Summary

Split off from #6370 as I think it's already a bug.

Problem 1

If you cylc trigger a task when there are no active flows (e.g. on restarting a completed workflow), it looks in the DB for the latest flow number(s). However, if the latest was flow=none, this would result in the task being triggered with flow=none as well.

Solution: choose the latest flow number(s) that is not flow=none.

Problem 2

With #6370 making it so that cylc remove will demote tasks to flow=none, you could end up with the situation where all tasks in the DB are flow=none, so again this would still result in the task being triggered with flow=none.

Solution: fall back to flow=1.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • Changelog entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the bug? Not sure if this is a bug or not label Oct 23, 2024
@MetRonnie MetRonnie added this to the 8.3.6 milestone Oct 23, 2024
@MetRonnie MetRonnie self-assigned this Oct 23, 2024
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks good, 👍

@oliver-sanders oliver-sanders merged commit b702dbb into cylc:8.3.x Oct 24, 2024
27 checks passed
@MetRonnie MetRonnie deleted the flow-nums branch October 24, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug? Not sure if this is a bug or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants