Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailwind shift update request form #5415

Merged
merged 2 commits into from
Apr 28, 2023
Merged

tailwind shift update request form #5415

merged 2 commits into from
Apr 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 27, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 3d04bb2

Removed max-w-4xl class from ConsultationForm component to improve layout on large screens. This was part of a UI improvement and bug fix PR for the consultation module.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3d04bb2

  • Removed max-w-4xl class from ConsultationForm component to fix layout issue on large screens (link)

@rithviknishad rithviknishad requested a review from a team April 27, 2023 14:03
@rithviknishad rithviknishad requested a review from a team as a code owner April 27, 2023 14:03
@rithviknishad rithviknishad requested a review from bodhish April 27, 2023 14:03
@vercel
Copy link

vercel bot commented Apr 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 4:22pm

@netlify
Copy link

netlify bot commented Apr 27, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3d04bb2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/644aa0fa3a5b430008d52d04
😎 Deploy Preview https://deploy-preview-5415--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1346a4f into develop Apr 28, 2023
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the tailwind/shift-update-form branch April 28, 2023 05:17
@rithviknishad rithviknishad mentioned this pull request Jun 22, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Shifting/ShiftDetailsUpdate.tsx:
3 participants
@rithviknishad @nihal467 @khavinshankar