Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace MUI CircularProgress #5136

Closed
wants to merge 3 commits into from
Closed

replace MUI CircularProgress #5136

wants to merge 3 commits into from

Conversation

ayushjnv1
Copy link
Contributor

@ayushjnv1 ayushjnv1 commented Mar 20, 2023 •
edited by rithviknishad
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@ayushjnv1 ayushjnv1 requested a review from a team March 20, 2023 19:27
@ayushjnv1 ayushjnv1 requested a review from a team as a code owner March 20, 2023 19:27
@ayushjnv1 ayushjnv1 requested a review from gigincg March 20, 2023 19:27
@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 26, 2023 at 8:16AM (UTC)

@netlify
Copy link

netlify bot commented Mar 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e0b3bd3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/641ffe6e51df000008a647a8
😎 Deploy Preview https://deploy-preview-5136--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayushjnv1
Copy link
Contributor Author

fix issue #4999

@ayushjnv1 ayushjnv1 requested review from rithviknishad and removed request for gigincg March 26, 2023 08:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

rithviknishad
rithviknishad requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushjnv1 we have a slight problem. All the below marked fields are coming from HelperInputFields which indirectly uses MaterialUI components.

Could you use the new FormField components for all fields in this page?

image

cc: @nihal467

@ayushjnv1
Copy link
Contributor Author

ok I will do that

@rithviknishad
Copy link
Member

rithviknishad commented Mar 27, 2023 •
edited
Loading

@ayushjnv1 if you could merge the latest develop branch now, you'll be able to see all the old components have been renamed to Legacy<ComponentName> so that it's easier to track which needs to be migrated.

Ref: 2c063da

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 21, 2023
@github-actions
Copy link

👋 Hi, @ayushjnv1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

Closing as completed via #5415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Shifting/ShiftDetailsUpdate.tsx:
3 participants
@ayushjnv1 @rithviknishad @nihal467