Issues/10813/scrolling issue

[MethodManav]

Proposed Changes

• Fixes Country Dropdown scroll issue in Patient Form #10813
• Fixed dropdown scrolling issue
• Enhanced the user experience.

Current behaviour

Screen.Recording.2025-02-25.at.11.28.22.PM.mov

@ohcnetwork/care-fe-code-reviewers

Summary by CodeRabbit

• New Features
  • Enhanced the phone input interface by introducing dynamic filtering in the country selection dropdown. Now, as users type their desired country name or code, the available options update in real time, making it faster and easier to locate and select the correct country.

[coderabbitai]

Walkthrough

This change enhances the country selection component by introducing a new state variable for holding filtered country results. A new function, handleScroll, is added to update the filtered list based on the user's input in the CommandInput component. This adjustment modifies how the list of countries is rendered within the CommandGroup, ensuring that users only see the results that match their search query.

Changes

File(s)	Change Summary
src/components/ui/phone-input.tsx	Added state variable filteredCountries initialized with countryList; introduced handleScroll(query: string) to update this state based on user input; modified CommandGroup rendering to display the filtered results.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CI as CommandInput
    participant CS as CountrySelect
    participant CG as CommandGroup

    U->>CI: Type search query
    CI->>CS: Trigger onValueChange with query
    CS->>CS: Execute handleScroll(query)
    CS->>CS: Update filteredCountries
    CS->>CG: Render filtered country list

Loading

Possibly related PRs

• fix(phone-input): implemented search functionality in country dropdown #10814: Introduces a similar filtering logic in the CountrySelect component by adding a handleSearch function and a state variable, aligning closely with the changes in this PR.

Suggested labels

invalid

Suggested reviewers

• rithviknishad

Poem

Hi, I'm Bunny, hopping in the code,
Filtering countries on a bright new road.
Keys tap-tap, the list gets lean,
A search so swift, a clean routine!
🐰 Keep hopping, keep coding—what a fun mode!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	83ce2ac
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67bf23943bb7190008c03b99
😎 Deploy Preview	https://deploy-preview-10829.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/components/ui/phone-input.tsx (2)

102-108: Feature implementation for country search filter

The addition of the filtered state and handler properly implements a search filtering mechanism for the country dropdown.

However, the function name handleScroll doesn't accurately describe its purpose, which is filtering the country list based on search input.

-  const handleScroll = (query: string) => {
+  const handleSearch = (query: string) => {

---

135-135: Proper integration with CommandInput

The onValueChange handler correctly connects the input changes to the filtering function.

Remember to update the function name reference if you change it as suggested above.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c097957 and 83ce2ac.

📒 Files selected for processing (1)

• src/components/ui/phone-input.tsx (2 hunks)

🔇 Additional comments (1)

src/components/ui/phone-input.tsx (1)

141-141: Using filtered results for display

Good implementation. Using the filteredCountries state variable instead of countryList properly displays only the countries that match the search query.

This change resolves the scrolling issue by ensuring only relevant results are rendered, making navigation more manageable.

[rithviknishad]

this doesn't solve the scroll issue though as already mentioned?

[MethodManav]

Hi @rithviknishad, can you explain it to me in more detail? What am I missing?