Fix : Alignment of Country List in Phone Number Search #10778

Jeffrin2005 · 2025-02-23T04:20:41Z

Proposed Changes

Fixes Improve Country List Alignment #10733
Used align="start" sideOffset={5}

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced the layout and positioning of the popover display within the country selection component. The responsive design improves usability on smaller screens, ensuring a polished and intuitive experience when interacting with the selection field.

coderabbitai · 2025-02-23T04:20:50Z

Walkthrough

The changes update the PopoverContent component within the CountrySelect function in the file src/components/ui/phone-input.tsx. The fixed width of 300px has been replaced with a dynamic width defined by the CSS variable --radix-popover-trigger-width. Padding adjustments have been made, and new properties align="start" and sideOffset={5} have been added to enhance the layout and positioning of the popover content without altering the core functionality.

Changes

File	Change Summary
src/components/ui/phone-input.tsx	Updated `PopoverContent` in `CountrySelect` to use dynamic width, adjust padding, and add new props for alignment and offset.

Possibly related PRs

Issues/10813/scrolling issue #10829: The changes in the main PR modify the layout and properties of the PopoverContent component in the CountrySelect function, while the retrieved PR introduces new state and filtering logic within the same CountrySelect component, indicating a direct relationship in terms of modifications to the same component.
fix(phone-input): implemented search functionality in country dropdown #10814: The changes in the main PR modify the layout and properties of the PopoverContent component within the CountrySelect function, while the retrieved PR introduces a search functionality in the same CountrySelect component, indicating a direct relationship between the two.

Suggested labels

needs review

Suggested reviewers

Jacobjeevan
nihal467

Poem

In the code garden, I hop with glee,
Adjusting popovers with precision and spree.
With align and sideOffset set just right,
My little code burrow shines ever so bright.
A joyful leap for neat UI, straight from this bunny's sight!
🐇💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec35a92 and 6c37105.

📒 Files selected for processing (1)

src/components/ui/phone-input.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/ui/phone-input.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: Test
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-23T04:21:06Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`6c37105`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67c07b04113173000863c764
😎 Deploy Preview	https://deploy-preview-10778.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jacobjeevan · 2025-02-25T08:45:47Z

Check the dropdown for other devices as well:

Jacobjeevan · 2025-02-26T09:18:08Z

src/components/ui/phone-input.tsx

@@ -120,7 +120,11 @@ const CountrySelect = ({
          />
        </Button>
      </PopoverTrigger>
-      <PopoverContent className="w-[300px] p-0">
+      <PopoverContent
+        className="w-[90vw] sm:w-[300px] p-2 sm:p-0"


See if you can make this work using --radix-popover-trigger-width variable (check for examples in codebase), so we don't use custom width here.

Jacobjeevan · 2025-02-26T12:45:51Z

src/components/ui/phone-input.tsx

@@ -121,7 +121,8 @@ const CountrySelect = ({
        </Button>
      </PopoverTrigger>
      <PopoverContent
-        className="w-[90vw] sm:w-[300px] p-2 sm:p-0"
+        className="p-2 sm:p-0"
+        style={{ width: "var(--radix-popover-trigger-width)" }}


you can use tailwind's custom width:

w-[var(--radix-popover-trigger-width)]

nihal467 · 2025-02-27T12:31:51Z

LGTM

src/components/ui/phone-input.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

github-actions · 2025-02-27T16:28:58Z

@Jeffrin2005 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

) Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

updated phone-input

2588ec0

Jeffrin2005 requested a review from a team as a code owner February 23, 2025 04:20

Jacobjeevan added the changes required label Feb 25, 2025

Responsive Design

bf93607

Jacobjeevan reviewed Feb 26, 2025

View reviewed changes

used radix-popover-trigger-width

ab124c0

Jacobjeevan reviewed Feb 26, 2025

View reviewed changes

used w-[var(--radix-popover-trigger-width)]

ec35a92

Jacobjeevan removed the changes required label Feb 27, 2025

Jacobjeevan approved these changes Feb 27, 2025

View reviewed changes

Jacobjeevan added needs testing needs review labels Feb 27, 2025

nihal467 added tested and removed needs testing labels Feb 27, 2025

rithviknishad requested changes Feb 27, 2025

View reviewed changes

src/components/ui/phone-input.tsx Outdated Show resolved Hide resolved

rithviknishad added changes required and removed needs review labels Feb 27, 2025

Update src/components/ui/phone-input.tsx

6c37105

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

rithviknishad approved these changes Feb 27, 2025

View reviewed changes

rithviknishad merged commit cf1292b into ohcnetwork:develop Feb 27, 2025
17 checks passed

ashwinpraveengo pushed a commit to ashwinpraveengo/care_fe that referenced this pull request Mar 2, 2025

Fix : Alignment of Country List in Phone Number Search (ohcnetwork#10778

5fd683d

) Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix : Alignment of Country List in Phone Number Search #10778

Fix : Alignment of Country List in Phone Number Search #10778

Jeffrin2005 commented Feb 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 23, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 23, 2025 •

edited

Loading

Jacobjeevan commented Feb 25, 2025

Jacobjeevan Feb 26, 2025

Jacobjeevan Feb 26, 2025

nihal467 commented Feb 27, 2025

github-actions bot commented Feb 27, 2025

Fix : Alignment of Country List in Phone Number Search #10778

Fix : Alignment of Country List in Phone Number Search #10778

Conversation

Jeffrin2005 commented Feb 23, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Feb 23, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 23, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

Jacobjeevan commented Feb 25, 2025

Jacobjeevan Feb 26, 2025

Choose a reason for hiding this comment

Jacobjeevan Feb 26, 2025

Choose a reason for hiding this comment

nihal467 commented Feb 27, 2025

github-actions bot commented Feb 27, 2025

Jeffrin2005 commented Feb 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 23, 2025 •

edited

Loading